-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter-prefix option to update config. #1083
base: main
Are you sure you want to change the base?
Conversation
b04c42e
to
ec49063
Compare
There is not currently a way to include only matching versions from the release update service This adds filter-prefix entry to Update section of melange.yaml. Specific use case for filter-prefix is a streamed package (ruby). After the corresponding change to make use of this filter lands in wolfi, then we can update ruby-3.2 to enable the release monitor like with: > update: > enabled: true > manual: true > filter-prefix: "3.2." > release-monitor: > identifier: 4223 Signed-off-by: Scott Moser <smoser@brickies.net>
ec49063
to
ee4923d
Compare
This relies on chainguard-dev/melange#1083 And allows adding an "include prefix" for update checks.
@@ -459,6 +459,8 @@ type Update struct { | |||
GitHubMonitor *GitHubMonitor `json:"github,omitempty" yaml:"github,omitempty"` | |||
// The configuration block for transforming the `package.version` into an APK version | |||
VersionTransform []VersionTransform `json:"version-transform,omitempty" yaml:"version-transform,omitempty"` | |||
// Prefix filter to apply when searching releases | |||
FilterPrefix string `json:"filter-prefix,omitempty" yaml:"filter-prefix,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if putting it under the update
block will cause confusion with the existing filter-prefix that is under the github
block? I.e. would it be better if we move this under the release-monitor
block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe Deprecate the 'TagFilterPrefix' in github block? filtering strings isn't really "provider specific".
I'm happy to do whatever you think is right.
I was just going through my open PRs. It feels like this is still useful. @rawlingsj I'm fine to close it or update it. let me know what you think is right. |
note to self, if this lands, need update to wolfctl also (as seen wolfi-dev/wolfictl#692) |
There is not currently a way to include only matching versions from the release update service
This adds filter-prefix entry to Update section of melange.yaml. Specific use case for filter-prefix is a streamed package (ruby).
After the corresponding change to make use of this filter lands in wolfi, then we can update ruby-3.2 to enable the release monitor like with:
Melange Pull Request Template
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: