Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow symlinks to provide cmd:" #1200

Merged
merged 1 commit into from
May 10, 2024

Conversation

joshrwolf
Copy link
Contributor

Reverts #1188

@joshrwolf joshrwolf merged commit 801d514 into main May 10, 2024
34 of 35 checks passed
@joshrwolf joshrwolf deleted the revert-1188-symlinks-are-cmd-too branch May 10, 2024 15:51
@xnox
Copy link
Contributor

xnox commented May 10, 2024

Current situation:

# apk add prometheus-config-reloader prometheus-co
nfig-reloader-oci-entrypoint-compat --latest
fetch https://packages.wolfi.dev/os/x86_64/APKINDEX.tar.gz
ERROR: unable to select packages:
  prometheus-config-reloader-0.73.2-r2:
    conflicts: prometheus-config-reloader-oci-entrypoint-compat-0.73.2-r2[cmd:prometheus-config-reloader=0.73.2-r2]
    satisfies: world[prometheus-config-reloader]
  prometheus-config-reloader-oci-entrypoint-compat-0.73.2-r2:
    conflicts: prometheus-config-reloader-0.73.2-r2[cmd:prometheus-config-reloader=0.73.2-r2]
    satisfies: world[prometheus-config-reloader-oci-entrypoint-compat]

with this revert

# apk add prometheus-config-reloader prometheus-config-reloader-oci-entrypoint-compat --latest
fetch https://packages.wolfi.dev/os/x86_64/APKINDEX.tar.gz
(1/2) Installing prometheus-config-reloader (0.73.2-r2)
(2/2) Installing prometheus-config-reloader-oci-entrypoint-compat (0.73.2-r2)
OK: 56 MiB in 16 packages
cc0fe839f5a7:/work/packages# 

it is all good.

@smoser
Copy link
Contributor

smoser commented May 14, 2024

For reference, the reversion of this started because of failures seen wolfi-dev/os#18857, wolfi-dev/os#18854, wolfi-dev/os#18853.

Two of them have errors during the apk test disqualified because ... already provides cmd:

I've created chainguard-dev/go-apk#264 as an issue to track the go-apk fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants