Only read the first line for shbang. #1213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/only-one-line-in-shbang
branch
from
7dd2fcd
to
eed1e30
Compare
I noticed this when I was playing with a shbang program like:
#!/usr/bin/env busybox sh
echo hello world
Melange would give a warning like this:
Error reading shbang from usr/bin/hello-busybox:
a shbang of only '/usr/bin/env' with multiple arguments
(6 /usr/bin/env busybox sh echo "hello world")
The new message would be:
Error reading shbang from usr/bin/hello-busybox:
a shbang of only '/usr/bin/env' with multiple arguments
(3 /usr/bin/env busybox sh)
Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
fix/only-one-line-in-shbang
branch
from
eed1e30
to
ad04838
Compare
|
Is there a test you could add to demonstrate the problem, and that this is the fix? Do you have an idea if there are packages in the wild that will produce different |
i could add a test.l I'm pretty sure this only affects the error path, in which there will be no provides generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when I was playing with a shbang program like:
#!/usr/bin/env busybox sh
echo hello world
Melange would give a warning like this:
Error reading shbang from usr/bin/hello-busybox:
a shbang of only '/usr/bin/env' with multiple arguments
(6 /usr/bin/env busybox sh echo "hello world")