fix: ignore resource requests for the docker runner #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
luhring
previously approved these changes
Jul 24, 2024
Signed-off-by: Jason Hall <jason@chainguard.dev>
luhring
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
resources:block to tell us what resources to give it when we run the build in a K8s pod (via wolfictl)It's been causing problems for the docker runner though, since some builds may request more resources than the local machine has, which fails the build.
This change drops support for resource requests in the docker runner, and as far as Melange is concerned, the resources block is now just informational. It's up to
wolfictl buildto make actual use of it.