More SBOM logic improvements #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://spdx.github.io/spdx-spec/v2.3/package-information/#721-external-reference-field Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
vaikas
reviewed
Aug 28, 2024
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
@vaikas There are no tests, and there haven't ever been as far as I can tell. 😞 We can add an E2E test that asserts the SBOM in an APK against a goldenfile or something. From what I can tell there's not yet a great place to put in tests for our SBOM logic, because of how tangled the data flow is throughout these giant structs that depend on mutations using data from all sorts of places. But I think this PR makes progress toward a more "testable" state, FWIW. |
jdolitsky
previously approved these changes
Aug 28, 2024
There appears to be an upstream issue with this package that should not block melange CI: https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/515 Also, it looks like this has happened before, see melange PR chainguard-dev#1143 that was later reverted in PR chainguard-dev#1147. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
jdolitsky
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues to improve the state of melange's SBOM code:
PACKAGE_MANAGERinstead ofPACKAGE-MANAGER.