fix(split pipelines): Don't split lib64 libraries #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/usr/local/*/lib64 was added to accomodate splitting away libraries used for development. This was incorrect. Now ALL libraries in /usr/local/*/lib64 get split away This fixes that and removes the behavior. We add `usr/` to library paths and that is sufficient for what we need Broken behavior introduced by me here: #1472 Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
jdolitsky
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/local/*/lib64 was added to accomodate splitting away libraries used for development. This was incorrect. Now ALL libraries in /usr/local/*/lib64 get split away
This fixes that and removes the behavior. We add
usr/to library paths and that is sufficient for what we needBroken behavior introduced by me here: #1472