pipelines: fix split/debug #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the variable substitution for the destination debug symbols results in one level of directories being expanded and substituted away. This breaks gdb automatic discovery of the debug symbols. Gdb is looking for /usr/lib/debug/usr/bin/openssl.debug, whilst current split/debug pipelines installs the dst to /usr/lib/debug/bin/openssl.debug instead. I think the substituition intends to strip the prefix path of the installed file, to achieve the intended path without the leading '/', e.g. usr/bin/openssl.debug. Thus make it do just that.
cpanato
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the variable substitution for the destination debug symbols
results in one level of directories being expanded and substituted
away. This breaks gdb automatic discovery of the debug symbols. Gdb is
looking for /usr/lib/debug/usr/bin/openssl.debug, whilst current
split/debug pipelines installs the dst to
/usr/lib/debug/bin/openssl.debug instead.
I think the substituition intends to strip the prefix path of the
installed file, to achieve the intended path without the leading '/',
e.g. usr/bin/openssl.debug. Thus make it do just that.