Do not specify versions during 'melange test' (Revert #1579 and #1518) #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1579 and chainguard-dev#1518) PR chainguard-dev#1518 was added with good reason, but it changed behavior that many wolfi tests depended on (see chainguard-dev#1579) for that use case. Revert both of those changes, restoring behavior to the way it was last week and thus restoring functional test of may wolfi packages. Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
revert/no-version-in-test
branch
from
c147d8e
to
73e18f4
Compare
xnox
approved these changes
Oct 21, 2024
imjasonh
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1518 was added with good reason, but it changed behavior that many wolfi tests depended on (see #1579) for that use case.
Revert both of those changes, restoring behavior to the way it was last week and thus restoring functional test of may wolfi packages.