Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines/cargo: ability to override the hardcoded output-dir #1661

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Nov 19, 2024

Some projects exports the binaries to different paths so that we couldn't use the cargo/build pipeline properly.

Example case here: wolfi-dev/os#34028

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

Some projects exports the binaries to different paths
so that we couldn't use the cargo/build pipeline properly.

Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax Dentrax changed the title pipelines/cargo: ability to override output-dir pipelines/cargo: ability to override the hardcoded output-dir Nov 19, 2024
Copy link
Contributor

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! this looks good.

@EyeCantCU EyeCantCU merged commit 4a2d679 into chainguard-dev:main Nov 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants