Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary util.Dedup and util.RightJoinMap methods #1705

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Dec 13, 2024

It's the future, we have generic slices and maps packages.

Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh enabled auto-merge December 13, 2024 22:14
jdolitsky
jdolitsky previously approved these changes Dec 13, 2024
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh changed the title remove unnecessary util.Dedup method remove unnecessary util.Dedup and util.RightJoinMap methods Dec 13, 2024
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

e2e failed with

2024/12/13 22:28:19 INFO running step "python/test"
2024/12/13 22:28:19 WARN Traceback (most recent call last):
2024/12/13 22:28:19 WARN   File "<string>", line 1, in <module>
2024/12/13 22:28:19 WARN ModuleNotFoundError: No module named 'numpy'
2024/12/13 22:28:19 INFO ERROR: failed to test package. the test environment has been preserved:
2024/12/13 22:28:19 INFO   workspace dir: /tmp/melange-workspace-2904734438
2024/12/13 22:28:19 INFO   guest dir: /tmp/melange-guest-608190734
2024/12/13 22:28:19 ERRO failed to test package: unable to run pipeline: unable to run pipeline: unable to run pipeline: exit status 1
ERROR[1]: Testing numpy-test from numpy-test.yaml

🤷

@jonjohnsonjr
Copy link
Contributor

Rebase to pick up ba60467

@imjasonh imjasonh merged commit 0e2b364 into chainguard-dev:main Dec 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants