melange bump: optional flag to modify git-checkout pipeline expected-… #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commit value Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
rawlingsj
force-pushed
the
expected_commit
branch
from
21481b3
to
950a315
Compare
imjasonh
reviewed
Apr 3, 2023
| newVersion string | ||
| expectedCommit string | ||
| }{ | ||
| {name: "expected_commit.yaml", newVersion: "7.0.1", expectedCommit: "dbd7bc96fd6cd383b8e895dc4a928d808541bb17"}, |
There was a problem hiding this comment.
Can this just be a single test that starts with what's currently at like 79? If there's only one case here, it's probably not worth the table-driven scaffolding.
There was a problem hiding this comment.
the test was generated from the IDE and does make it easier for folks adding new cases but TBH I don't mind either way. Happy to switch it to a single test if you prefer. FWIW as this is merged I have opened a second PR to discuss as I did noticed that the test data meant the test didn't actually verify the new sha was correct. #368
jdolitsky
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…commit value