Refactor some pipelines to more safely use pipeline expansions #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was possible to do something like:
pipeline:
- uses: fetch
with:
uri: http://example.com/release.tgz; exit 0
expected-sha256: ...
Which would allow the checksum validation to be skipped.
Found by Cure53.
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
The patches variable is ultimately just an inline list of patches to apply. Convert it to a series file and unify the patching pipeline. Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Previously, it was possible to have a block such as
pipeline:
- uses: git-checkout
with:
repository: https://example.com/foo.git; exit 1
Or
pipeline:
- uses: git-checkout
with:
repository: https://example.com/foo.git
depth: "; exit 1"
Harden the variable expansions to prevent this.
Found by Cure53.
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
jdolitsky
approved these changes
Jul 17, 2023
joshrwolf
reviewed
Jul 17, 2023
joshrwolf
approved these changes
Jul 17, 2023
|
Maybe we should have some sort of checker (e.g. shellcheck) that validates our pipeline shell scripts continuously in CI? |
mattmoor
reviewed
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.