Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCA refactoring, part 1 #793

Merged
merged 6 commits into from
Oct 26, 2023
Merged

SCA refactoring, part 1 #793

merged 6 commits into from
Oct 26, 2023

Conversation

kaniini
Copy link
Contributor

@kaniini kaniini commented Oct 26, 2023

This refactors the SCA engine into its own package, adds an abstraction layer that a test harness could be built around and cleans up the current SCA analyzers to properly use VFS operations.

This does not add a SCA test harness, or tests, as we still need to do a bit of refactoring of the SCA analyzers to make them more testable.

Melange Pull Request Template

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
…mand

Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini kaniini requested a review from imjasonh October 26, 2023 18:21
@imjasonh imjasonh merged commit 97b459b into main Oct 26, 2023
28 checks passed
@imjasonh imjasonh deleted the refactor/sca branch October 26, 2023 18:39
epsilon-phase pushed a commit to epsilon-phase/melange that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants