Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny cleanup: Move test pipelines to where others are. Remove unnecessary test packages. #912

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

vaikas
Copy link
Member

@vaikas vaikas commented Jan 2, 2024

Move the pkg/test/pipelines/... into pkg/build/pipelines, so they get added as embedded pipelines into melange binary and there's no need to specify their location separately. This way it's consistent with the other pipelines.

wolfi-base has already a dependency on busybox, and there's no reason to include apk tools, just drop wolfi-base from the example tests for clarity and use busybox. For py3-pandas, the package should already have a dep on python, so don't add it into the tests also.

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

…ages.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas enabled auto-merge January 2, 2024 23:55
@vaikas vaikas merged commit b73fa7a into chainguard-dev:main Jan 3, 2024
31 of 32 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants