Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement apko rule #1

Merged
merged 6 commits into from
Sep 14, 2023
Merged

feat: implement apko rule #1

merged 6 commits into from
Sep 14, 2023

Conversation

thesayyn
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

.bazelrc Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
apk_fetch_helper.py Outdated Show resolved Hide resolved
apko/BUILD.bazel Outdated Show resolved Hide resolved
apko/defs.bzl Outdated Show resolved Hide resolved
apko/repositories.bzl Outdated Show resolved Hide resolved
apko/repositories.bzl Show resolved Hide resolved
examples/lock/apko.yaml Show resolved Hide resolved
@imjasonh
Copy link
Member

This looks like a great start! I'm fine merging this as-is, or addressing any of @alexeagle's comments.

Some things I can't quite parse from this in its current state:

  1. what's the process for a consumer upgrading a package to a new version? The apko.yaml doesn't change, but what updates the lockfile?
  2. how does this integrate with other rules_oci-compatible things like cosign_attest etc?

And as a general high-level comment, I think we should bias examples toward Wolfi packages, even though Alpine packages should definitely work too. Not that this has to happen in this initial PR, and it might be a good example for me to try this out after this lands.

examples/lock/apko.lock.json Outdated Show resolved Hide resolved
apko/private/apk.bzl Outdated Show resolved Hide resolved
apk_fetch_helper.py Outdated Show resolved Hide resolved
@thesayyn thesayyn force-pushed the apko_rule branch 3 times, most recently from 460ae73 to af52db9 Compare September 14, 2023 21:37
@thesayyn thesayyn merged commit 7053776 into main Sep 14, 2023
7 of 8 checks passed
.apko/range.sh Show resolved Hide resolved
# Generated by apko_bazelrc. DO NOT EDIT
# Required for range requests for fetching the apk packages.
# https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests
# Use https://www.base64decode.org/ to see what this base64 encoded command does.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have some public location talking about the problem and this clever solution, maybe a blog.aspect.dev post to start with? Or something on docs.aspect.build?

@@ -0,0 +1,24 @@
# Initial setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this file got excluded from code review, is .gitattributes over-matching ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should docs/initial-setup.md linguist-generated=false do the trick?

docs/initial-setup.md Show resolved Hide resolved
MODULE.bazel Show resolved Hide resolved
apko/private/apko_image.bzl Show resolved Hide resolved
apko/private/versions.bzl Show resolved Hide resolved
examples/lock/BUILD.bazel Show resolved Hide resolved
scripts/mirror_apko.sh Show resolved Hide resolved
resolve.sh Show resolved Hide resolved
@mattmoor mattmoor deleted the apko_rule branch March 9, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants