-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement apko rule #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
This looks like a great start! I'm fine merging this as-is, or addressing any of @alexeagle's comments. Some things I can't quite parse from this in its current state:
And as a general high-level comment, I think we should bias examples toward Wolfi packages, even though Alpine packages should definitely work too. Not that this has to happen in this initial PR, and it might be a good example for me to try this out after this lands. |
460ae73
to
af52db9
Compare
# Generated by apko_bazelrc. DO NOT EDIT | ||
# Required for range requests for fetching the apk packages. | ||
# https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests | ||
# Use https://www.base64decode.org/ to see what this base64 encoded command does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have some public location talking about the problem and this clever solution, maybe a blog.aspect.dev post to start with? Or something on docs.aspect.build?
@@ -0,0 +1,24 @@ | |||
# Initial setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this file got excluded from code review, is .gitattributes over-matching ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should docs/initial-setup.md linguist-generated=false
do the trick?
No description provided.