Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cache and rule docs #10

Merged
merged 1 commit into from
Sep 16, 2023
Merged

docs: add cache and rule docs #10

merged 1 commit into from
Sep 16, 2023

Conversation

thesayyn
Copy link
Collaborator

No description provided.

@thesayyn thesayyn mentioned this pull request Sep 15, 2023
@@ -2,6 +2,11 @@

load("//apko/private:util.bzl", "parse_lock", "sanitize_string")

_DOC = """Repository rule to generate starlark code from an `apko.lock.json` file.

See [apko-cache.md](./apko-cache.md) documentation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe that apko-cache.md should just move here?

"lock": attr.label(mandatory = True),
"target_name": attr.string(doc = "internal"),
"lock": attr.label(doc = "label to the `apko.lock.json` file.", mandatory = True),
"target_name": attr.string(doc = "internal. do not use!"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you cannot make it private? (Underscore prefix)

@alexeagle alexeagle merged commit eb7c404 into main Sep 16, 2023
8 checks passed
@alexeagle alexeagle deleted the docs branch September 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants