Integrate with apko-0.13+ . Pass --lockfile to apko to get hermetic (re)builds.
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
reviewed
Dec 11, 2023
thesayyn
reviewed
Dec 11, 2023
thesayyn
reviewed
Dec 11, 2023
thesayyn
reviewed
Dec 11, 2023
thesayyn
reviewed
Dec 11, 2023
sfc-gh-ptabor
force-pushed
the
20231211-apko12-resolved-file-support
branch
from
9244eb1
to
4d381e3
Compare
sfc-gh-ptabor
changed the title
--resolved-file to apko to get hermetic (re)builds.--resolved-file to apko to get hermetic (re)builds.
sfc-gh-ptabor
force-pushed
the
20231211-apko12-resolved-file-support
branch
2 times, most recently
from
ffe4a9d
to
f704714
Compare
Signed-off-by: Piotr Tabor <piotr.tabor@snowflake.com>
sfc-gh-ptabor
force-pushed
the
20231211-apko12-resolved-file-support
branch
from
f704714
to
9df0d61
Compare
sfc-gh-ptabor
force-pushed
the
20231211-apko12-resolved-file-support
branch
from
9df0d61
to
9a3e878
Compare
…metic (re)builds. Signed-off-by: Piotr Tabor <piotr.tabor@snowflake.com>
sfc-gh-ptabor
force-pushed
the
20231211-apko12-resolved-file-support
branch
from
9a3e878
to
06e9f0d
Compare
sfc-gh-ptabor
changed the title
--resolved-file to apko to get hermetic (re)builds.--lockfile to apko to get hermetic (re)builds.
…ko13. Signed-off-by: Piotr Tabor <piotr.tabor@snowflake.com>
|
@thesayyn -> The PR is ready for another pass. Thank you. |
thesayyn
reviewed
Dec 21, 2023
thesayyn
reviewed
Dec 21, 2023
thesayyn
approved these changes
Dec 22, 2023
|
@sfc-gh-ptabor tests are failing. |
|
@thesayyn . Thank you for the approval. Refreshed the lock files. I hope it will pass now... but I'm not sure as I cannot run full CICD myself (need approval). PTAL. |
auto-merge was automatically disabled
December 28, 2023 19:30
Head branch was pushed to by a user without write access
imjasonh
pushed a commit
that referenced
this pull request
Jan 18, 2024
…th apko 0.13+) (#47) This PR is on top of: #41. Please review only the last commit: [Rename .resolve targets (deprecated) to .lock targets.](7ff68b2) Rename .resolve targets (deprecated) to .lock targets. This makes the naming uniform across apko (0.13+) and rules_apko. The old rules still exist, but emit a warning. From now going on, please use: `*.lock.json` file naming instead of `*.resolved.json`. Also `bazel run .../image.resolve` rule is deprecated and instead `bazel run .../image.lock` should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate with apko-0.12+ . Pass
--lockfileto apko to get hermetic (re)builds.This is
rules_apkopart of: #13that integrates: