Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allow_empty = True in apk src globbing #73

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apko/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,16 @@ bzl_library(
],
)

bzl_library(
name = "toolchain",
srcs = ["toolchain.bzl"],
visibility = ["//visibility:public"],
)

# Enables calling apko tool directly by bazel.
# To resolve given `./apko.yaml` file into `./apko.lock.json`, once can call:
# e.g. (cd ./examples/oci; bazel run @rules_apko//apko lock ./apko.yaml)
apko_run(
name = "apko",
visibility = ["//visibility:public"],
)

bzl_library(
name = "toolchain",
srcs = ["toolchain.bzl"],
visibility = ["//visibility:public"],
)
12 changes: 6 additions & 6 deletions apko/private/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")

exports_files(srcs = ["apko_config.tmpl.sh"])

bzl_library(
name = "apko_config",
srcs = ["apko_config.bzl"],
visibility = ["//apko:__subpackages__"],
)

bzl_library(
name = "apk",
srcs = ["apk.bzl"],
Expand Down Expand Up @@ -44,6 +38,12 @@ bzl_library(
deps = [":apko_run"],
)

bzl_library(
name = "apko_config",
srcs = ["apko_config.bzl"],
visibility = ["//apko:__subpackages__"],
)

bzl_library(
name = "resolved_toolchain",
srcs = ["resolved_toolchain.bzl"],
Expand Down
5 changes: 4 additions & 1 deletion apko/private/apk.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ APK_IMPORT_TMPL = """\
# Generated by apk_import. DO NOT EDIT
filegroup(
name = "all",
srcs = glob(["**/*.tar.gz", "**/*.apk"]),
srcs = glob(
["**/*.tar.gz", "**/*.apk"],
allow_empty = True,
),
visibility = ["//visibility:public"]
)
"""
Expand Down
Loading