Allow users to provide the versions of apko binaries not listed in versions.bzl #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions.bzl Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
…rsions.bzl Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
…rsions.bzl Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
…rsions.bzl Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
sfc-gh-mhazy
changed the title
imjasonh
approved these changes
Jun 13, 2024
Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
auto-merge was automatically disabled
June 13, 2024 20:49
Head branch was pushed to by a user without write access
Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
Signed-off-by: Mateusz Hazy <mateusz.hazy@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here is to be able to use newest apko releases without updating rules_apko as an intermediate step.
It offloads some complexity (specifying hash, prefix to strip and url to the user), but if one just wants to use default apko version, they don't need to do it.