Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #17

Closed
wants to merge 7 commits into from
Closed

Code cleanup #17

wants to merge 7 commits into from

Commits on Mar 8, 2024

  1. Remove Floating Pragmas

    Will likely be picked up in audits as SWC-103 https://swcregistry.io/docs/SWC-103/
    Tranquil-Flow committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    efbf474 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary declaration of abicoder v2

    As per Solidity 0.8.0, ABI coder v2 is activated by default and as such it does not need to be specified in the code. Disregard this commit if wanting to be explicit in using ABI coder v2  instead of experimental ABIEncoderV2 or abicoder V1.
    Tranquil-Flow committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    61b7fac View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary fallback() functions

    In `FeeCollector.sol`, `PositionFactory.sol` and `AdminService.sol`, both a fallback() and receive() function are specified. No code is executed in these contracts upon receiving ether, therefore, fallback() can be omitted as it is redundant.
    Tranquil-Flow committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f79c7b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    9d2a56b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    d9cd361 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    58ee7dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acd2657 View commit details
    Browse the repository at this point in the history