Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add protocol fee #7

Merged
merged 3 commits into from
Jan 24, 2024
Merged

feat: add protocol fee #7

merged 3 commits into from
Jan 24, 2024

Conversation

cucupac
Copy link
Contributor

@cucupac cucupac commented Jan 23, 2024

No description provided.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (75cb729) 100.00% compared to head (1702472) 88.31%.

❗ Current head 1702472 differs from pull request most recent head 03cf022. Consider uploading reports for the commit 03cf022 to get more accurate results

Files Patch % Lines
src/FeeCollector.sol 35.71% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main       #7       +/-   ##
============================================
- Coverage   100.00%   88.31%   -11.69%     
============================================
  Files            5        6        +1     
  Lines           58       77       +19     
============================================
+ Hits            58       68       +10     
- Misses           0        9        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/FeeCollector.sol Outdated Show resolved Hide resolved
src/FeeCollector.sol Show resolved Hide resolved
src/Position.sol Outdated Show resolved Hide resolved
src/Position.sol Outdated Show resolved Hide resolved
test/Position.t.sol Outdated Show resolved Hide resolved
@cucupac cucupac merged commit ed5961b into main Jan 24, 2024
1 of 2 checks passed
@cucupac cucupac deleted the protocol_fee branch January 24, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants