Test PR

.github/ISSUE_TEMPLATE/question.md

@@ -6,4 +6,4 @@ labels: 'type:docs'
 assignees: ''
 ---
 
-This should only be used in very rare cases e.g. if you are not 100% sure if something is a bug or asking a question that leads to improving the documentation. For general questions please use [Erigon's discord](https://discord.gg/hQ2dxbNZ).
+This should only be used in very rare cases e.g. if you are not 100% sure if something is a bug or asking a question that leads to improving the documentation. For general questions please use [Erigon's discord](https://github.com/ledgerwatch/erigon#erigon-discord-server).

.github/workflows/ci.yml

@@ -28,25 +28,15 @@ jobs:
         os: [ ubuntu-20.04, macos-11 ] # list of os: https://github.com/actions/virtual-environments
     runs-on: ${{ matrix.os }}
 
-    steps:      
+    steps:
       - uses: actions/checkout@v3
-      - run: git submodule update --init --recursive --force
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.19.x
+          go-version: '1.19'
       - name: Install dependencies on Linux
         if: runner.os == 'Linux'
         run: sudo apt update && sudo apt install build-essential
 
-      - uses: actions/cache@v3
-        with:
-          path: |
-            ~/.cache/go-build
-            ~/Library/Caches/go-build
-            ~/go/pkg/mod
-          key: go-${{ matrix.os }}-${{ hashFiles('**/go.sum') }}
-          restore-keys: go-${{ matrix.os }}-
-
       - name: Build
         run: make all
 
@@ -64,27 +54,23 @@ jobs:
         if: runner.os == 'Linux'
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.51
+          version: v1.52
 
       - name: Test
         run: make test
 
-#      - name: Test HistoryV3
-#        run: make test3
-
   tests-windows:
     if: ${{ github.event_name == 'push' || !github.event.pull_request.draft }}
     strategy:
       matrix:
         os: [ windows-2022 ]
     runs-on: ${{ matrix.os }}
 
-    steps:      
+    steps:
       - uses: actions/checkout@v3
-      - run: git submodule update --init --recursive --force
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.19.x
+          go-version: '1.19'
 
       - uses: actions/cache@v3
         with:
@@ -97,14 +83,6 @@ jobs:
           choco upgrade mingw -y --no-progress --version 11.2.0.07112021
           choco install cmake -y --no-progress --version 3.23.1
 
-      - uses: actions/cache@v3
-        with:
-          path: |
-            ~\AppData\Local\go-build
-            ~\go\pkg\mod
-          key: go-${{ matrix.os }}-${{ hashFiles('**/go.sum') }}
-          restore-keys: go-${{ matrix.os }}-
-
       - name: Build
         run: .\wmake.ps1 all
 
@@ -129,11 +107,11 @@ jobs:
         run: sudo DOCKER_TAG=thorax/erigon:ci-$GITHUB_SHA DOCKER_UID=$(id -u) DOCKER_GID=$(id -g) make docker
 
   automated-tests:
-      runs-on:
-        ubuntu-20.04
-      if: ${{ github.event_name == 'push' || !github.event.pull_request.draft }}
-      steps:
-        - uses: actions/checkout@v3
-      
-        - name: run automated testing
-          run: BUILD_ERIGON=1 ./tests/automated-testing/run.sh
+    runs-on:
+      ubuntu-20.04
+    if: ${{ github.event_name == 'push' || !github.event.pull_request.draft }}
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: run automated testing
+        run: BUILD_ERIGON=1 ./tests/automated-testing/run.sh

.github/workflows/coverage.yml

@@ -10,11 +10,9 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - run: git submodule update --init --recursive --force
-
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.19.x
+          go-version: '1.19'
 
       - name: install dependencies on Linux
         if: runner.os == 'Linux'

.github/workflows/test-integration.yml

@@ -7,6 +7,8 @@ on:
       - stable
   schedule:
     - cron: '20 16 * * *' # daily at 16:20 UTC
+  workflow_dispatch:
+
 jobs:
   tests:
     strategy:
@@ -17,22 +19,13 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - run: git submodule update --init --recursive --force
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.19.x
+          go-version: '1.19'
       - name: Install dependencies on Linux
         if: runner.os == 'Linux'
         run: sudo apt update && sudo apt install build-essential
 
-      - uses: actions/cache@v3
-        with:
-          path: |
-            ~/.cache/go-build
-            ~/Library/Caches/go-build
-            ~/go/pkg/mod
-          key: go-${{ matrix.os }}-${{ hashFiles('**/go.sum') }}
-          restore-keys: go-${{ matrix.os }}-
-
       - name: test-integration
         run: make test-integration
 
@@ -48,9 +41,9 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - run: git submodule update --init --recursive --force
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.19.x
+          go-version: '1.19'
 
       - uses: actions/cache@v3
         with:
@@ -63,13 +56,5 @@ jobs:
           choco upgrade mingw -y --no-progress --version 11.2.0.07112021
           choco install cmake -y --no-progress --version 3.23.1
 
-      - uses: actions/cache@v3
-        with:
-          path: |
-            ~\AppData\Local\go-build
-            ~\go\pkg\mod
-          key: go-${{ matrix.os }}-${{ hashFiles('**/go.sum') }}
-          restore-keys: go-${{ matrix.os }}-
-
       - name: test-integration
         run: .\wmake.ps1 test-integration

.golangci.yml

@@ -2,22 +2,35 @@ run:
   deadline: 10m
 
 linters:
-  disable-all: true
+  presets:
+    - bugs
+    - error
+    - unused
+    - performance
+  disable:
+    - exhaustive
+    - musttag
+    - contextcheck
+    - wrapcheck
+    - goerr113
+    - unparam
+    - makezero #TODO: enable me
+    - noctx #TODO: enable me
+    - nilerr #TODO: enable me
+    - errorlint #TODO: enable me
+    - errchkjson #TODO: enable me
+    - unused #TODO: enable me
+    - gocheckcompilerdirectives
   enable:
+    - unconvert
+    #    - predeclared #TODO: enable me
+    #    - thelper #TODO: enable me
+    #    - wastedassign
     - gofmt
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
-#    - structcheck # 1.18
-#    - unused # 1.18
     - gocritic
-    - bodyclose
-    - gosec
+#    - revive
 #    - forcetypeassert
-    - prealloc
-    - unconvert
+#    - stylecheck
 
 linters-settings:
   gocritic:

.goreleaser.yml

@@ -14,7 +14,7 @@ builds:
     env:
       - CC=o64-clang
       - CXX=o64-clang++
-    tags: [ nosqlite, noboltdb ]
+    tags: [ nosqlite, noboltdb, netgo ]
     ldflags: -s -w
 
   - id: darwin-arm64
@@ -25,7 +25,7 @@ builds:
     env:
       - CC=oa64-clang
       - CXX=oa64-clang++
-    tags: [ nosqlite, noboltdb ]
+    tags: [ nosqlite, noboltdb, netgo ]
     ldflags: -s -w
 
   - id: linux-amd64
@@ -36,7 +36,7 @@ builds:
     env:
       - CC=x86_64-linux-gnu-gcc
       - CXX=x86_64-linux-gnu-g++
-    tags: [ nosqlite, noboltdb ]
+    tags: [ nosqlite, noboltdb, netgo ]
     ldflags: -s -w -extldflags "-static" # We need to build a static binary because we are building in a glibc based system and running in a musl container
 
   - id: linux-arm64
@@ -47,7 +47,7 @@ builds:
     env:
       - CC=aarch64-linux-gnu-gcc
       - CXX=aarch64-linux-gnu-g++
-    tags: [ nosqlite, noboltdb ]
+    tags: [ nosqlite, noboltdb, netgo ]
     ldflags: -s -w -extldflags "-static" # We need to build a static binary because we are building in a glibc based system and running in a musl container
 
   - id: windows-amd64
@@ -58,7 +58,7 @@ builds:
     env:
       - CC=x86_64-w64-mingw32-gcc
       - CXX=x86_64-w64-mingw32-g++
-    tags: [ nosqlite, noboltdb ]
+    tags: [ nosqlite, noboltdb, netgo ]
     ldflags: -s -w
 
 

Makefile

@@ -28,7 +28,7 @@ CGO_CFLAGS += -Wno-error=strict-prototypes # for Clang15, remove it when can htt
 CGO_CFLAGS := CGO_CFLAGS="$(CGO_CFLAGS)"
 DBG_CGO_CFLAGS += -DMDBX_DEBUG=1
 
-BUILD_TAGS = nosqlite,noboltdb
+BUILD_TAGS = nosqlite,noboltdb,netgo # about netgo see: https://github.com/golang/go/issues/30310#issuecomment-471669125
 PACKAGE = github.com/ledgerwatch/erigon
 
 GO_FLAGS += -trimpath -tags $(BUILD_TAGS) -buildvcs=false
@@ -42,8 +42,8 @@ default: all
 
 ## go-version:                        print and verify go version
 go-version:
-	@if [ $(shell $(GO) version | cut -c 16-17) -lt 18 ]; then \
-		echo "minimum required Golang version is 1.18"; \
+	@if [ $(shell $(GO) version | cut -c 16-17) -lt 19 ]; then \
+		echo "minimum required Golang version is 1.19"; \
 		exit 1 ;\
 	fi
 
@@ -166,7 +166,7 @@ lintci:
 ## lintci-deps:                       (re)installs golangci-lint to build/bin/golangci-lint
 lintci-deps:
 	rm -f ./build/bin/golangci-lint
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./build/bin v1.51.2
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./build/bin v1.52.1
 
 ## clean:                             cleans the go cache, build dir, libmdbx db dir
 clean: