Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number conversion #378

Merged
merged 12 commits into from
Apr 1, 2021
+966 −636
Merged

Number conversion #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
44488ea
Add ConvertValueAtPath
asdine Mar 31, 2021
f1eb5cf
Split tests
asdine Mar 31, 2021
e11fd11
Ignore errors in Convert
asdine Mar 31, 2021
7b4f147
Fix inferred constraint with primary key
asdine Mar 31, 2021
c25e2e6
Remove int to double conversion
asdine Mar 31, 2021
fabd206
Allow null values
asdine Mar 31, 2021
5ae6420
Add MakeArray helper
asdine Mar 31, 2021
10661fa
Allow mixed number comparison
asdine Mar 31, 2021
da8b28c
Test array comparison with numbers
asdine Mar 31, 2021
c61be86
Add constraints conversion strategies
asdine Mar 31, 2021
ce8ee69
Strict index selection
asdine Mar 31, 2021
1d74f6e
Add missing primary key type on read only tables
asdine Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions database/catalog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ func (c *Catalog) Load(tx *Transaction) error {
FieldName: "table_name",
},
},
Type: document.TextValue,
IsPrimaryKey: true,
},
},
Expand All @@ -58,6 +59,7 @@ func (c *Catalog) Load(tx *Transaction) error {
FieldName: "index_name",
},
},
Type: document.TextValue,
IsPrimaryKey: true,
},
},
Expand Down
18 changes: 18 additions & 0 deletions database/catalog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ import (
"errors"
"testing"

"github.com/genjidb/genji"
"github.com/genjidb/genji/database"
"github.com/genjidb/genji/document"
"github.com/genjidb/genji/testutil"
"github.com/stretchr/testify/require"
)

Expand Down Expand Up @@ -662,3 +664,19 @@ func TestReIndexAll(t *testing.T) {
require.Equal(t, clone, catalog)
})
}

func TestReadOnlyTables(t *testing.T) {
db, err := genji.Open(":memory:")
require.NoError(t, err)
defer db.Close()

doc, err := db.QueryDocument(`CREATE TABLE foo; SELECT * FROM __genji_tables`)
require.NoError(t, err)

testutil.RequireDocJSONEq(t, doc, `{"field_constraints": [], "read_only":false, "store_name":"dAE=", "table_name":"foo"}`)

doc, err = db.QueryDocument(`CREATE INDEX idx_foo_a ON foo(a); SELECT * FROM __genji_indexes`)
require.NoError(t, err)

testutil.RequireDocJSONEq(t, doc, `{"index_name":"idx_foo_a", "path":["a"], "table_name":"foo", "unique":false}`)
}
Loading