Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .timer command. #445

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Add .timer command. #445

merged 2 commits into from
Feb 20, 2022

Conversation

tzzed
Copy link
Contributor

@tzzed tzzed commented Feb 11, 2022

This is a proposal for #443.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #445 (6f77506) into main (d8a0bff) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   79.50%   79.61%   +0.11%     
==========================================
  Files          95       95              
  Lines        9655     9659       +4     
==========================================
+ Hits         7676     7690      +14     
+ Misses       1327     1322       -5     
+ Partials      652      647       -5     
Impacted Files Coverage Δ
internal/sql/parser/drop.go 56.25% <0.00%> (ø)
internal/sql/parser/alter.go 75.60% <0.00%> (ø)
internal/sql/parser/delete.go 39.13% <0.00%> (ø)
internal/tree/tree.go 86.50% <0.00%> (+1.58%) ⬆️
internal/database/table.go 92.68% <0.00%> (+2.43%) ⬆️
types/encoding/encoding.go 87.20% <0.00%> (+7.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a0bff...6f77506. Read the comment docs.

Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tzzed ! Just one comment

cmd/genji/shell/shell.go Outdated Show resolved Hide resolved
@tzzed tzzed requested a review from asdine February 20, 2022 14:32
Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asdine asdine merged commit 2282f4b into chaisql:main Feb 20, 2022
@asdine asdine mentioned this pull request Feb 20, 2022
paralin pushed a commit to paralin/genji that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants