Skip to content

Commit

Permalink
[1.6>master] [MERGE #3129 @Penguinwizzard] Fix a few issues blocking …
Browse files Browse the repository at this point in the history
…ASAN runs

Merge pull request #3129 from Penguinwizzard:fix_asan_ci

Disable one test in ASAN due to a known issue with modules in ch (bug #2735), disable one test on xplat due to wasm calling convention issues (bug #2378), keep a loop from accessing data beyond an array bound in the pal code, and fix the casing on one test file.
  • Loading branch information
Penguinwizzard committed Jun 9, 2017
2 parents d71f43e + 07bb54c commit a73911f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pal/src/cruntime/wchar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,7 @@ PAL_wmemcmp(
const size_t *num1 = (const size_t*)(string1);
const size_t *num2 = (const size_t*)(string2);

while( (count > blockSize * wi) && num1[wi] == num2[wi] ) ++wi;
while( (count > blockSize * (wi + 1)) && num1[wi] == num2[wi] ) ++wi;

for (i = blockSize * wi; i < count; ++i)
{
Expand Down
2 changes: 1 addition & 1 deletion test/es6/rlexe.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1415,7 +1415,7 @@
<default>
<files>bug_issue_3076.js</files>
<compile-flags>-force:deferparse</compile-flags>
<tags>BugFix</tags>
<tags>BugFix,exclude_sanitize_address</tags>
</default>
</test>
<test>
Expand Down
File renamed without changes.
1 change: 1 addition & 0 deletions test/wasm/rlexe.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
<files>basic.js</files>
<baseline>basic.baseline</baseline>
<compile-flags>-wasm</compile-flags>
<tags>exclude_xplat</tags>
</default>
</test>
<test>
Expand Down

0 comments on commit a73911f

Please sign in to comment.