Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xplat: Date/formatting.js fails with jit on #1593

Closed
jianchun opened this issue Sep 17, 2016 · 1 comment
Closed

xplat: Date/formatting.js fails with jit on #1593

jianchun opened this issue Sep 17, 2016 · 1 comment
Assignees
@obastemur
Milestone
Cross-platform

Comments

@jianchun
Copy link

With "-Test" build, there is one weird PDT/PST error (from mktime call) during the loop of test cases. Excluded in #1591.
@jianchun
Copy link
Author

@obastemur

@obastemur obastemur self-assigned this Sep 17, 2016
@dilijev dilijev added the Bug label Oct 17, 2016
@dilijev dilijev modified the milestone: Cross-platform Oct 17, 2016
@obastemur obastemur removed the Bug label Jan 12, 2017
@obastemur obastemur mentioned this issue Jan 13, 2017
Merged
chakrabot pushed a commit that referenced this issue Jan 27, 2017
@obastemur
[MERGE #2376 @obastemur] xplat: match posix / unix date output and fi…
5265c95 
…x JIT Date issue.

Merge pull request #2376 from obastemur:add_xplat_date_formatting

Fixes #1593

Initially xplat posix Date implementation was matching (at least it was trying!) with Windows OldDateAPI. However, we are unable to meet some of the edge cases + number inconsistencies among the distros.

Remove all the bad hacks on posix imp. and match results to posix / unix default instead + add an additional test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obastemur obastemur

Labels
None yet
Projects
None yet
Milestone
Cross-platform
Development

No branches or pull requests
3 participants
@dilijev @obastemur @jianchun