Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing ETW events for the JIT queue may crash in stress scenarios. #5631

Closed
VSadov opened this issue Aug 24, 2018 · 0 comments
Closed

Tracing ETW events for the JIT queue may crash in stress scenarios. #5631

VSadov opened this issue Aug 24, 2018 · 0 comments
Assignees
@VSadov
Labels
Bug Severity: 1

Comments

@VSadov
Copy link
Contributor

VSadov commented Aug 24, 2018

Only a problem when producing JSCRIPT_FUNCTION_JIT_QUEUED or JSCRIPT_FUNCTION_JIT_DEQUEUED events.

That calls GetDisplayName helper that may miscalculate the length of the source name and read extra chars, causing a crash in stress scenarios.
@VSadov VSadov self-assigned this Aug 24, 2018
@VSadov VSadov mentioned this issue Aug 24, 2018
Merged
VSadov added a commit to VSadov/ChakraCore that referenced this issue Aug 24, 2018
@VSadov
Fix incorrect length of display name when tracing ETW events for the …
522adf7 
…JIT queue.

Fixes:chakra-core#5631
chakrabot pushed a commit that referenced this issue Aug 24, 2018
@VSadov
[MERGE #5632 @VSadov] Fix incorrect length of display name when traci…
ebe9f3f 
…ng ETW events for the JIT queue.

Merge pull request #5632 from VSadov:fix5631

Fix incorrect length of display name when tracing ETW events for the JIT queue.

Fixes:#5631
chakrabot pushed a commit that referenced this issue Aug 24, 2018
@VSadov
[1.11>master] [MERGE #5632 @VSadov] Fix incorrect length of display n…
d3ac17e 
…ame when tracing ETW events for the JIT queue.

Merge pull request #5632 from VSadov:fix5631

Fix incorrect length of display name when tracing ETW events for the JIT queue.

Fixes:#5631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VSadov VSadov

Labels
Bug Severity: 1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dilijev @VSadov