-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A native application for running native unittests. #1224
Conversation
|
||
#pragma warning(disable:4100) // unreferenced formal parameter | ||
|
||
namespace JsRTApiTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are transformed from our full repo. So the intent of the tests have not been changed.
@digitalinfinity @dilijev @ianwjhalliday @EdMaurer have a look. |
Looks LoadScriptFile conflicts with changes in Linux branch |
thanks @jianchun, I'll have a look at those. Also please have a look at the changes wrt to cross plat. I haven't done anything specific to enable that. That would be next stage. |
@akroshg We will need to discuss whether it is appropriate to add the Microsoft copyright notice to If that code is licensed under a different license we might need to update /cc @EdMaurer @liminzhu on that decision. For reference, full output of copyright check:
|
Sure @dilijev, I have initiated offline discussion for this. |
Strange, *_release branch failures do not show up in the our buddy build system. @dilijev do you know if there are difference in between those? |
@akroshg I think you mean the PreFAST warnings? The commands run in buddy builds are slightly different from the Jenkins scripts. We should probably add PreFAST analysis there. PreFAST analysis is only performed in release builds so that's why it only shows up in the release flavors. You can see To repro, you'll need to run:
|
Can I run it by |
// | ||
// Read the entire content as a binary block. | ||
// | ||
fread((void*)contentsRaw, sizeof(char), lengthBytes, file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the assumption fread
has read entire content is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akroshg Is there a reason that you haven't change this one before merging?
RE: the assumption fread has read entire content is wrong
This looks good to me at first glance. Some checkin gates have failed but overall I don't see anything I'd change about the approach taken. |
This application is based upon the Catch framework (Open source). Most our internal tests are transformed from the TE to adopt the catch framework.
This application is based upon the Catch framework (Open source). Most our internal tests are transformed from the TE to adopt the catch framework.