xplat: enable wasm and test cases #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables Wasm on xplat Test and Debug builds. Once the remaning test cases are fixed, will be enabled for release builds too
Closed
|
@dotnet-bot test ALL please |
|
LGTM; there's still the issue of #2378, but given that our x-plat asm.js already has that as well, it shouldn't block this commit imo. |
chakrabot
pushed a commit
that referenced
this pull request
Feb 9, 2017
Merge pull request #2473 from obastemur:wasm_in This PR enables Wasm on xplat Test and Debug builds. Once the remaning test cases are fixed, will be enabled for release builds too
|
@Penguinwizzard Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Wasm on xplat Test and Debug builds. Once the remaning test cases are fixed, will be enabled for release builds too