Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSRT weak reference APIs #2948

Merged
merged 6 commits into from
May 11, 2017
Merged

Add JSRT weak reference APIs #2948

merged 6 commits into from
May 11, 2017

Commits on May 9, 2017

  1. Add JSRT weak-reference APIs

    @jasongin
    jasongin committed May 9, 2017
    Configuration menu
    Copy the full SHA
    deb0a4e View commit details
    Browse the repository at this point in the history

  2. Add native test for weak references

    @jasongin
    jasongin committed May 9, 2017
    Configuration menu
    Copy the full SHA
    671c390 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Address review feedback in weak-reference APIs

    @jasongin
    jasongin committed May 10, 2017
    Configuration menu
    Copy the full SHA
    5ea344e View commit details
    Browse the repository at this point in the history

  2. Move weak-reference test to JsRTApiTest.cpp

    @jasongin
    jasongin committed May 10, 2017
    Configuration menu
    Copy the full SHA
    617966a View commit details
    Browse the repository at this point in the history

  3. More review feedback for weak-reference APIs 

     - Move new APIs from ChakraCommon.h to ChakraCore.h, conditional on CHAKRACOREBUILD_
 - Call FindOrCreateWeakReferenceHandle() instead of CreateWeakReferenceHandle()
    @jasongin
    jasongin committed May 10, 2017
    Configuration menu
    Copy the full SHA
    042db69 View commit details
    Browse the repository at this point in the history

  4. Fix weakref exports conditional

    @jasongin
    jasongin committed May 10, 2017
    Configuration menu
    Copy the full SHA
    7c2439e View commit details
    Browse the repository at this point in the history