Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename /lib/ files to CamelCase #303

Merged
merged 1 commit into from
Feb 13, 2016
Merged

Conversation

jianchun
Copy link

We had a mix of inconsistent file name styles. This creates problems on
Linux as we had to modify source code includes to the same casing as real
file names. This change attempts rename (most) /lib/ files to CamelCase.

lib/Backend                         =>  Lib/Backend

     BackEnd.cpp                             Backend.cpp
     BackEnd.h                               Backend.h
     BackEndOpcodeAttrAsmJs.cpp              BackendOpCodeAttrAsmJs.cpp
     BackEndOpcodeAttrAsmJs.h                BackendOpCodeAttrAsmJs.h
     BackEndOpCodeList.h                     BackendOpCodeList.h
     CodegenNumberAllocator.cpp              CodeGenNumberAllocator.cpp
     GlobOptBailout.cpp                      GlobOptBailOut.cpp
     SCCLiveness.cpp                         SccLiveness.cpp
     SCCLiveness.h                           SccLiveness.h


lib/Backend/amd64                   =>  Lib/Backend/amd64

     MdOpcodes.h                             MdOpCodes.h


lib/Backend/arm                     =>  Lib/Backend/arm

     MdOpcodes.h                             MdOpCodes.h


lib/Backend/arm64                   =>  Lib/Backend/arm64

     MdOpcodes.h                             MdOpCodes.h


lib/Backend/i386                    =>  Lib/Backend/i386

     MdOpcodes.h                             MdOpCodes.h


lib/common                          =>  Lib/Common

     BackEndAPI.h                            BackendApi.h
     commoninl.h                             CommonInl.h
     resource.h                              Resource.h


lib/common/common                   =>  Lib/Common/Common

     cfglogger.cpp                           CfgLogger.cpp
     cfglogger.h                             CfgLogger.h
     GetCurrentFrameID.h                     GetCurrentFrameId.h
     int16math.h                             Int16Math.h
     SmartFPUControl.cpp                     SmartFpuControl.cpp
     SmartFPUControl.h                       SmartFpuControl.h


lib/common/core                     =>  Lib/Common/Core

     api.h                                   Api.h
     AutoFILE.h                              AutoFile.h


lib/common/DataStructures           =>  Lib/Common/DataStructures

     comparer.h                              Comparer.h
     dictionary.h                            Dictionary.h
     Dlist.h                                 DList.h
     growingArray.cpp                        GrowingArray.cpp
     growingArray.h                          GrowingArray.h
     interval.h                              Interval.h
     list.h                                  List.h
     stack.h                                 Stack.h


lib/common/Exceptions               =>  Lib/Common/Exceptions

     reporterror.cpp                         ReportError.cpp
     reporterror.h                           ReportError.h


lib/common/Memory                   =>  Lib/Common/Memory

     collectionstate.h                       CollectionState.h
     heapblock.inl                           HeapBlock.inl
     heapbucket.cpp                          HeapBucket.cpp
     heapbucket.h                            HeapBucket.h
     heapbucket.inl                          HeapBucket.inl
     heapinfo.cpp                            HeapInfo.cpp
     heapinfo.h                              HeapInfo.h
     leakreport.cpp                          LeakReport.cpp
     leakreport.h                            LeakReport.h


lib/common/util                     =>  Lib/Common/Util

     pinned.cpp                              Pinned.cpp
     pinned.h                                Pinned.h


lib/jsrt                            =>  Lib/Jsrt

     chakracommon.h                          ChakraCommon.h
     jsrtcontext.cpp                         JsrtContext.cpp
     jsrtcontext.h                           JsrtContext.h
     jsrtExternalObject.cpp                  JsrtExternalObject.cpp
     jsrtExternalObject.h                    JsrtExternalObject.h
     jsrtinternal.h                          JsrtInternal.h
     jsrtRuntime.cpp                         JsrtRuntime.cpp
     jsrtRuntime.h                           JsrtRuntime.h
     jsrtThreadService.cpp                   JsrtThreadService.cpp
     jsrtThreadService.h                     JsrtThreadService.h


lib/Parser                          =>  Lib/Parser

     alloc.cpp                               Alloc.cpp
     alloc.h                                 Alloc.h
     hash.cpp                                Hash.cpp
     hash.h                                  Hash.h
     hashfunc.cpp                            HashFunc.cpp
     jsscan.js                               JsScan.js
     parse.cpp                               Parse.cpp
     parse.h                                 Parse.h
     regcodes.h                              RegCodes.h
     RegexOpcodes.h                          RegexOpCodes.h
     RegexRunTime.cpp                        RegexRuntime.cpp
     RegexRunTime.h                          RegexRuntime.h
     scan.cpp                                Scan.cpp
     scan.h                                  Scan.h


lib/Runtime/Base                    =>  Lib/Runtime/Base

     scriptcontextbase.h                     ScriptContextBase.h
     ThreadContextTLSEntry.cpp               ThreadContextTlsEntry.cpp
     ThreadContextTLSEntry.h                 ThreadContextTlsEntry.h
     threadservicewrapper.h                  ThreadServiceWrapper.h


lib/Runtime/ByteCode                =>  Lib/Runtime/ByteCode

     AsmJSByteCodeDumper.cpp                 AsmJsByteCodeDumper.cpp
     AsmJSByteCodeDumper.h                   AsmJsByteCodeDumper.h
     BackEndOpcodeAttr.cpp                   BackendOpCodeAttr.cpp
     BackEndOpcodeAttr.h                     BackendOpCodeAttr.h
     ByteCodeAPI.h                           ByteCodeApi.h
     byteCodeCacheReleaseFileVersion.h       ByteCodeCacheReleaseFileVersion.h
     Opcodes.cpp                             OpCodes.cpp


lib/Runtime/Language                =>  Lib/Runtime/Language

     asmjs.cpp                               AsmJs.cpp
     AsmJS.h                                 AsmJs.h
     AsmJsBuiltinNames.h                     AsmJsBuiltInNames.h
     AsmJSBytecodeGenerator.cpp              AsmJsByteCodeGenerator.cpp
     AsmJSBytecodeGenerator.h                AsmJsByteCodeGenerator.h
     AsmJSCodeGenerator.cpp                  AsmJsCodeGenerator.cpp
     AsmJSCodeGenerator.h                    AsmJsCodeGenerator.h
     AsmJSEncoder.cpp                        AsmJsEncoder.cpp
     AsmJSEncoder.h                          AsmJsEncoder.h
     AsmJSEncoder.inl                        AsmJsEncoder.inl
     AsmJSEncoderHandler.inl                 AsmJsEncoderHandler.inl
     AsmJSJitTemplate.h                      AsmJsJitTemplate.h
     AsmJSLink.cpp                           AsmJsLink.cpp
     AsmJSLink.h                             AsmJsLink.h
     AsmJSModule.cpp                         AsmJsModule.cpp
     AsmJSModule.h                           AsmJsModule.h
     AsmJSTypes.cpp                          AsmJsTypes.cpp
     AsmJSTypes.h                            AsmJsTypes.h
     AsmJSUtils.cpp                          AsmJsUtils.cpp
     AsmJSUtils.h                            AsmJsUtils.h
     SIMDBool16x8Operation.cpp               SimdBool16x8Operation.cpp
     SIMDBool16x8Operation.h                 SimdBool16x8Operation.h
     SIMDBool16x8OperationX86X64.cpp         SimdBool16x8OperationX86X64.cpp
     SIMDBool32x4Operation.cpp               SimdBool32x4Operation.cpp
     SIMDBool32x4Operation.h                 SimdBool32x4Operation.h
     SIMDBool32x4OperationX86X64.cpp         SimdBool32x4OperationX86X64.cpp
     SIMDBool8x16Operation.cpp               SimdBool8x16Operation.cpp
     SIMDBool8x16Operation.h                 SimdBool8x16Operation.h
     SIMDBool8x16OperationX86X64.cpp         SimdBool8x16OperationX86X64.cpp
     SIMDFloat32x4Operation.cpp              SimdFloat32x4Operation.cpp
     SIMDFloat32x4Operation.h                SimdFloat32x4Operation.h
     SIMDfloat32x4OperationX86X64.cpp        SimdFloat32x4OperationX86X64.cpp
     SIMDFloat64x2Operation.cpp              SimdFloat64x2Operation.cpp
     SIMDFloat64x2Operation.h                SimdFloat64x2Operation.h
     SIMDfloat64x2OperationX86X64.cpp        SimdFloat64x2OperationX86X64.cpp
     SIMDInt16x8Operation.cpp                SimdInt16x8Operation.cpp
     SIMDInt16x8Operation.h                  SimdInt16x8Operation.h
     SIMDInt16x8OperationX86X64.cpp          SimdInt16x8OperationX86X64.cpp
     SIMDInt32x4Operation.cpp                SimdInt32x4Operation.cpp
     SIMDInt32x4Operation.h                  SimdInt32x4Operation.h
     SIMDInt32x4OperationX86X64.cpp          SimdInt32x4OperationX86X64.cpp
     SIMDInt8x16Operation.cpp                SimdInt8x16Operation.cpp
     SIMDInt8x16Operation.h                  SimdInt8x16Operation.h
     SIMDInt8x16OperationX86X64.cpp          SimdInt8x16OperationX86X64.cpp
     SIMDUint16x8Operation.cpp               SimdUint16x8Operation.cpp
     SIMDUint16x8Operation.h                 SimdUint16x8Operation.h
     SIMDUint16x8OperationX86X64.cpp         SimdUint16x8OperationX86X64.cpp
     SIMDUInt32x4Operation.cpp               SimdUint32x4Operation.cpp
     SIMDUInt32x4Operation.h                 SimdUint32x4Operation.h
     SIMDUInt32x4OperationX86X64.cpp         SimdUint32x4OperationX86X64.cpp
     SIMDUint8x16Operation.cpp               SimdUint8x16Operation.cpp
     SIMDUint8x16Operation.h                 SimdUint8x16Operation.h
     SIMDUint8x16OperationX86X64.cpp         SimdUint8x16OperationX86X64.cpp
     SIMDUtils.cpp                           SimdUtils.cpp
     SIMDUtils.h                             SimdUtils.h


lib/Runtime/Language/amd64          =>  Lib/Runtime/Language/amd64

     AsmJSJitTemplate.cpp                    AsmJsJitTemplate.cpp
     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h
     stackframe.inl                          StackFrame.inl


lib/Runtime/Language/arm            =>  Lib/Runtime/Language/arm

     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h


lib/Runtime/Language/arm64          =>  Lib/Runtime/Language/arm64

     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h


lib/Runtime/Language/i386           =>  Lib/Runtime/Language/i386

     AsmJSJitTemplate.cpp                    AsmJsJitTemplate.cpp
     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h


lib/Runtime/Library                 =>  Lib/Runtime/Library

     dataview.cpp                            DataView.cpp
     dataview.h                              DataView.h
     JavascriptSIMDBool16x8.cpp              JavascriptSimdBool16x8.cpp
     JavascriptSIMDBool16x8.h                JavascriptSimdBool16x8.h
     JavascriptSIMDBool32x4.cpp              JavascriptSimdBool32x4.cpp
     JavascriptSIMDBool32x4.h                JavascriptSimdBool32x4.h
     JavascriptSIMDBool8x16.cpp              JavascriptSimdBool8x16.cpp
     JavascriptSIMDBool8x16.h                JavascriptSimdBool8x16.h
     JavascriptSIMDFloat32x4.cpp             JavascriptSimdFloat32x4.cpp
     JavascriptSIMDFloat32x4.h               JavascriptSimdFloat32x4.h
     JavascriptSIMDFloat64x2.cpp             JavascriptSimdFloat64x2.cpp
     JavascriptSIMDFloat64x2.h               JavascriptSimdFloat64x2.h
     JavascriptSIMDInt16x8.cpp               JavascriptSimdInt16x8.cpp
     JavascriptSIMDInt16x8.h                 JavascriptSimdInt16x8.h
     JavascriptSIMDInt32x4.cpp               JavascriptSimdInt32x4.cpp
     JavascriptSIMDInt32x4.h                 JavascriptSimdInt32x4.h
     JavascriptSIMDInt8x16.cpp               JavascriptSimdInt8x16.cpp
     JavascriptSIMDInt8x16.h                 JavascriptSimdInt8x16.h
     JavascriptSIMDUint16x8.cpp              JavascriptSimdUint16x8.cpp
     JavascriptSIMDUint16x8.h                JavascriptSimdUint16x8.h
     JavascriptSIMDUInt32x4.cpp              JavascriptSimdUint32x4.cpp
     JavascriptSIMDUInt32x4.h                JavascriptSimdUint32x4.h
     JavascriptSIMDUint8x16.cpp              JavascriptSimdUint8x16.cpp
     JavascriptSIMDUint8x16.h                JavascriptSimdUint8x16.h
     javascripttypednumber.cpp               JavascriptTypedNumber.cpp
     javascripttypednumber.h                 JavascriptTypedNumber.h
     moduleroot.cpp                          ModuleRoot.cpp
     moduleroot.h                            ModuleRoot.h
     SIMDBool16x8Lib.cpp                     SimdBool16x8Lib.cpp
     SIMDBool16x8Lib.h                       SimdBool16x8Lib.h
     SIMDBool32x4Lib.cpp                     SimdBool32x4Lib.cpp
     SIMDBool32x4Lib.h                       SimdBool32x4Lib.h
     SIMDBool8x16Lib.cpp                     SimdBool8x16Lib.cpp
     SIMDBool8x16Lib.h                       SimdBool8x16Lib.h
     SIMDFloat32x4Lib.cpp                    SimdFloat32x4Lib.cpp
     SIMDFloat32x4Lib.h                      SimdFloat32x4Lib.h
     SIMDFloat64x2Lib.cpp                    SimdFloat64x2Lib.cpp
     SIMDFloat64x2Lib.h                      SimdFloat64x2Lib.h
     SIMDInt16x8Lib.cpp                      SimdInt16x8Lib.cpp
     SIMDInt16x8Lib.h                        SimdInt16x8Lib.h
     SIMDInt32x4Lib.cpp                      SimdInt32x4Lib.cpp
     SIMDInt32x4Lib.h                        SimdInt32x4Lib.h
     SIMDInt8x16Lib.cpp                      SimdInt8x16Lib.cpp
     SIMDInt8x16Lib.h                        SimdInt8x16Lib.h
     SIMDUint16x8Lib.cpp                     SimdUint16x8Lib.cpp
     SIMDUint16x8Lib.h                       SimdUint16x8Lib.h
     SIMDUInt32x4Lib.cpp                     SimdUint32x4Lib.cpp
     SIMDUInt32x4Lib.h                       SimdUint32x4Lib.h
     SIMDUint8x16Lib.cpp                     SimdUint8x16Lib.cpp
     SIMDUint8x16Lib.h                       SimdUint8x16Lib.h
     typedArrayEnumerator.cpp                TypedArrayEnumerator.cpp
     typedArrayEnumerator.h                  TypedArrayEnumerator.h


lib/Runtime/Library/amd64           =>  Lib/Runtime/Library/amd64

     javascriptfunctiona.asm                 JavascriptFunctionA.asm


lib/Runtime/Library/InJavascript    =>  Lib/Runtime/Library/InJavascript

     intl.js.bc.32b.h                        Intl.js.bc.32b.h
     intl.js.bc.64b.h                        Intl.js.bc.64b.h

@msftclas
Copy link

Hi @jianchun, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Jianchun Xu). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dilijev
Copy link
Contributor

dilijev commented Feb 11, 2016

I definitely approve.

A concern here is that it might be very difficult to merge this change into various feature branches because of the renames. I looked into this a bit and it seems like the "easiest" thing to do might be to rename all the files in a commit off the original branch point and then rebase the entire branch on top of the rename commit so that as far as git is concerned, all the changes in the branch were always with respect to the newly-named files, but it sounded pretty fragile to me, and for published branches this is not an acceptable approach.

I haven't tried this yet, but it might work if you made a similar commit in each feature branch before merging master into those branches (linux, etc.). Git will either figure it out and merge correctly or it will complain that the new files were added in both branches, and might give you a chance to resolve the issue.

@dilijev
Copy link
Contributor

dilijev commented Feb 11, 2016

For the various *SIMD* files, I think the general recommendation in camelCase and PascalCase is to only capitalize the first letter of an acronym to make it easier to see the "word" boundaries.

Example: XmlReader instead of XMLReader

However since SIMD in all-CAPS is a convention we've already used in the code, I think it's reasonable to go with SIMD in these names.

In all cases, when the file is named after a type, the file name should have the same casing as the type.

@ianwjhalliday
Copy link
Collaborator

Agree with Simd over SIMD. Also Cfg over CFG and any others I missed.

@tfarina
Copy link

tfarina commented Feb 11, 2016

@jianchun Thanks for pushing this forward!

@jianchun
Copy link
Author

@dilijev Thanks for the info! I'll try a merge in feature branch to see how intelligent git is.

@ianwjhalliday @dilijev Yes, exactly because the code used SIMD... CFG... as class names.

@tfarina Thanks for filing the issue and discussion.

@jianchun
Copy link
Author

Agree with Simd over SIMD. Also Cfg over CFG and any others I missed.

@ianwjhalliday @dilijev One option is to have Simd, Cfg (and Api as I recall) in file names here. We can refactor the code later. What do you think?

@ianwjhalliday
Copy link
Collaborator

Ah the class names I see. Yes, I think renaming the files now in the desired casing is a good start and then changing the class names later if we find time.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

As for rules on acronyms in PascalCase/camelCase, I just found a handy article by Microsoft:

https://msdn.microsoft.com/en-us/library/141e06ef(v=vs.71).aspx

When using acronyms, use Pascal case or camel case for acronyms more than two characters long. For example, use HtmlButton or htmlButton. However, you should capitalize acronyms that consist of only two characters, such as System.IO instead of System.Io.

So we should use IR instead of Ir.

However since ID is an abbreviation of identifier rather than an acronym I'm not sure whether we should use ID or Id.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@jianchun @ianwjhalliday Yes, I agree we should fix the filenames in one go since this is probably more traumatic than refactoring the type names later, which we can do more easily on an as-seen basis.

@jianchun You're already doing this but I'll reiterate: renames should be done in a commit separately from any other changes to help Git realize the renames easier.

That said, in a separate commit, might it be a good idea to add TODOs on the classes that should be renamed?

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

MdOpcodes.h MdOpCodes.h

Not sure how I feel about camel casing this particular example. "opcode" is a single-word abbreviation of "operation code". But I think we already have types that are spelled with OpCode... In this case I would go with the convention in our code, I guess.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@dotnet-bot test Windows x64_test please

@MikeHolman
Copy link
Contributor

Do we know how Windows machines will handle this/what (if anything) people will need to do to merge their changes after this goes through? On StackOverflow, the results I'm seeing for this topic are pretty scary.

@MikeHolman
Copy link
Contributor

Also, I prefer "Backend" over "BackEnd", as backend is one word. It's also less invasive (only a couple files vs. moving whole directory).

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

+1 on Backend.

@jianchun
Copy link
Author

Not sure how I feel about camel casing this particular example. "opcode" is a single-word abbreviation of "operation code". But I think we already have types that are spelled with OpCode... In this case I would go with the convention in our code, I guess.

Yes, we have most code spells OpCode. So I kept it.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

Yes, we have most code spells OpCode. So I kept it.

SGTM

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

Since there's no good way to track progress on this kind of code review I made myself a table. I'll check off items as I look.

  • lib/Parser => Lib/Parser
    • alloc.cpp Alloc.cpp
    • scan.h Scan.h
    • hash.h Hash.h
    • jsscan.js JsScan.js
    • parse.h Parse.h
    • hash.cpp Hash.cpp
    • parse.cpp Parse.cpp
    • regcodes.h RegCodes.h
    • scan.cpp Scan.cpp
    • RegexOpcodes.h RegexOpCodes.h
    • RegexRunTime.h RegexRuntime.h
    • alloc.h Alloc.h
    • hashfunc.cpp HashFunc.cpp // there are some recommendations not to use abbreviations like Func but since we all know what it means, it seems fine
    • RegexRunTime.cpp RegexRuntime.cpp
  • lib/common/common => Lib/Common/Common
    • cfglogger.h CFGLogger.h // Cfg instead of CFG
    • int16math.h Int16Math.h
    • cfglogger.cpp CFGLogger.cpp // Cfg
  • lib/common/DataStructures => Lib/Common/DataStructures
    • dictionary.h Dictionary.h
    • Dlist.h DList.h
    • comparer.h Comparer.h
    • growingArray.h GrowingArray.h
    • interval.h Interval.h
    • stack.h Stack.h
    • growingArray.cpp GrowingArray.cpp
    • list.h List.h
  • lib/common/Exceptions => Lib/Common/Exceptions
    • reporterror.cpp ReportError.cpp
    • reporterror.h ReportError.h
  • lib/common/Memory => Lib/Common/Memory
    • heapinfo.cpp HeapInfo.cpp
    • leakreport.h LeakReport.h
    • heapbucket.h HeapBucket.h
    • collectionstate.h CollectionState.h
    • heapbucket.inl HeapBucket.inl
    • heapblock.inl HeapBlock.inl
    • heapbucket.cpp HeapBucket.cpp
    • heapinfo.h HeapInfo.h
    • leakreport.cpp LeakReport.cpp
  • lib/common => Lib/Common
    • resource.h Resource.h
    • commoninl.h CommonInl.h
  • lib/common/util => Lib/Common/Util
    • pinned.cpp Pinned.cpp
    • pinned.h Pinned.h
  • lib/jsrt => Lib/Jsrt // I'm not sure whether this should be Jsrt or JSRT since it's just the word by itself and it's an established acronym.
    • jsrtcontext.h JsrtContext.h
    • jsrtThreadService.h JsrtThreadService.h
    • jsrtRuntime.h JsrtRuntime.h
    • jsrtThreadService.cpp JsrtThreadService.cpp
    • jsrtRuntime.cpp JsrtRuntime.cpp
    • chakracommon.h ChakraCommon.h // this seems a bit out of place given the rest of the files in this dir. Is there possibly a better place?
    • jsrtinternal.h JsrtInternal.h
    • jsrtcontext.cpp JsrtContext.cpp
    • jsrtExternalObject.cpp JsrtExternalObject.cpp
    • jsrtExternalObject.h JsrtExternalObject.h
  • lib/Backend => Lib/BackEnd // Backend should not change.
    • GlobOptSimd128.cpp GlobOptSIMD128.cpp // Simd instead of SIMD (no change)
  • lib/Backend/i386 => Lib/BackEnd/i386
    • MdOpcodes.h MdOpCodes.h // a bit weird, but we're keeping it
  • lib/Backend => Lib/BackEnd
    • LowerMDSharedSimd128.cpp LowerMDSharedSIMD128.cpp // keep Simd
  • lib/Backend/arm => Lib/BackEnd/arm
    • MdOpcodes.h MdOpCodes.h
  • lib/Backend => Lib/BackEnd
    • BackEndOpcodeAttrAsmJs.h BackEndOpCodeAttrAsmJs.h
    • BackEndOpcodeAttrAsmJs.cpp BackEndOpCodeAttrAsmJs.cpp
    • CodegenNumberAllocator.cpp CodeGenNumberAllocator.cpp
    • Chakra.Backend.vcxproj.filters Chakra.BackEnd.vcxproj.filters // keep Backend
  • lib/Backend/amd64 => Lib/BackEnd/amd64
    • MdOpcodes.h MdOpCodes.h
  • lib/Backend/arm64 => Lib/BackEnd/arm64
    • MdOpcodes.h MdOpCodes.h
  • lib/Backend => Lib/BackEnd
    • Chakra.Backend.vcxproj Chakra.BackEnd.vcxproj // keep Backend
    • GlobOptBailout.cpp GlobOptBailOut.cpp // do we want to commit to Bailout being two words throughout the code?
  • lib/Runtime/Language => Lib/Runtime/Language
    • AsmJSUtils.h AsmJsUtils.h
    • SimdOps.h SIMDOps.h // keep Simd
    • AsmJSCodeGenerator.cpp AsmJsCodeGenerator.cpp
    • AsmJSCodeGenerator.h AsmJsCodeGenerator.h
    • AsmJSEncoder.h AsmJsEncoder.h
    • AsmJSJitTemplate.h AsmJsJitTemplate.h
    • AsmJSBytecodeGenerator.h AsmJsByteCodeGenerator.h // in filenames we see more ByteCode than Bytecode (these are the only two instances of Bytecode I can see). 'git grep ... | wc' shows that there are 145 lines containing Bytecode and 2552 lines containing ByteCode. We should make it an item to refactor the instances of Bytecode to ByteCode so everything is consistent.
    • AsmJSBytecodeGenerator.cpp AsmJsByteCodeGenerator.cpp
    • AsmJSEncoder.inl AsmJsEncoder.inl
    • SIMDfloat64x2OperationX86X64.cpp SIMDFloat64x2OperationX86X64.cpp // change to Simd
    • AsmJSUtils.cpp AsmJsUtils.cpp
    • AsmJSLink.cpp AsmJsLink.cpp
    • SIMDUInt32x4Operation.cpp SIMDUint32x4Operation.cpp // change to Simd
  • lib/Runtime/Language/i386 => Lib/Runtime/Language/i386 // I agree with this but just want to make sure, i386 is intentionally lowercase, right?
    • AsmJSJitTemplate.cpp AsmJsJitTemplate.cpp
    • stackframe.cpp StackFrame.cpp
    • stackframe.h StackFrame.h
  • lib/Runtime/Language => Lib/Runtime/Language
    • AsmJsBuiltinNames.h AsmJsBuiltInNames.h // this is another instance where we are inconsistent across filenames and source -- in both cases about half and half
  • lib/Runtime/Language/arm => Lib/Runtime/Language/arm // did you mean to keep this as 'arm' and not 'ARM'?
    • stackframe.cpp StackFrame.cpp
    • stackframe.h StackFrame.h
  • lib/Runtime/Language => Lib/Runtime/Language
    • SIMDfloat32x4OperationX86X64.cpp SIMDFloat32x4OperationX86X64.cpp // change to Simd
    • AsmJSEncoderHandler.inl AsmJsEncoderHandler.inl
    • AsmJSTypes.h AsmJsTypes.h
    • AsmJSModule.cpp AsmJsModule.cpp
  • lib/Runtime/Language/amd64 => Lib/Runtime/Language/amd64 `// did you mean to keep this as 'amd64' and not 'AMD64'?
    • AsmJSJitTemplate.cpp AsmJsJitTemplate.cpp
    • stackframe.cpp StackFrame.cpp
    • stackframe.h StackFrame.h
    • stackframe.inl StackFrame.inl
  • lib/Runtime/Language => Lib/Runtime/Language
    • AsmJSTypes.cpp AsmJsTypes.cpp
  • lib/Runtime/Language/arm64 => Lib/Runtime/Language/arm64
    • stackframe.cpp StackFrame.cpp
    • stackframe.h StackFrame.h
  • lib/Runtime/Language => Lib/Runtime/Language
    • AsmJSModule.h AsmJsModule.h
    • AsmJSLink.h AsmJsLink.h
    • AsmJSEncoder.cpp AsmJsEncoder.cpp
    • SIMDUInt32x4OperationX86X64.cpp SIMDUint32x4OperationX86X64.cpp // Simd
    • asmjs.cpp AsmJs.cpp
    • SIMDUInt32x4Operation.h SIMDUint32x4Operation.h // Simd
  • lib/Runtime/Base => Lib/Runtime/Base
    • threadservicewrapper.h ThreadServiceWrapper.h
    • scriptcontextbase.h ScriptContextBase.h
  • lib/Runtime/Library => Lib/Runtime/Library
    • javascripttypednumber.h JavascriptTypedNumber.h
    • SIMDUInt32x4Lib.h SIMDUint32x4Lib.h
    • moduleroot.cpp ModuleRoot.cpp
    • typedArrayEnumerator.cpp TypedArrayEnumerator.cpp
    • dataview.h DataView.h
    • SimdLib.h SIMDLib.h // Simd
    • SIMDUInt32x4Lib.cpp SIMDUint32x4Lib.cpp // Simd
  • lib/Runtime/Library/InJavascript => Lib/Runtime/Library/InJavascript
    • intl.js.bc.32b.h Intl.js.bc.32b.h
    • intl.js.bc.64b.h Intl.js.bc.64b.h
  • lib/Runtime/Library => Lib/Runtime/Library
    • dataview.cpp DataView.cpp
    • JavascriptSIMDUInt32x4.h JavascriptSIMDUint32x4.h // Simd
  • lib/Runtime/Library/amd64 => Lib/Runtime/Library/amd64
    • javascriptfunctiona.asm JavascriptFunctionA.asm
  • lib/Runtime/Library => Lib/Runtime/Library
    • javascripttypednumber.cpp JavascriptTypedNumber.cpp
    • typedArrayEnumerator.h TypedArrayEnumerator.h
    • JavascriptSIMDUInt32x4.cpp JavascriptSIMDUint32x4.cpp
    • moduleroot.h ModuleRoot.h
  • lib/Runtime/ByteCode => Lib/Runtime/ByteCode
    • OpCodesSimd.h OpCodesSIMD.h // Simd
    • BackEndOpcodeAttr.cpp BackEndOpCodeAttr.cpp
    • byteCodeCacheReleaseFileVersion.h ByteCodeCacheReleaseFILEVersion.h // keep File
    • AsmJSByteCodeDumper.cpp AsmJsByteCodeDumper.cpp
    • AsmJSByteCodeDumper.h AsmJsByteCodeDumper.h
    • BackEndOpcodeAttr.h BackEndOpCodeAttr.h
    • Opcodes.cpp OpCodes.cpp

@jianchun
Copy link
Author

Also, I prefer "Backend" over "BackEnd", as backend is one word. It's also less invasive (only a couple files vs. moving whole directory).

+1 on Backend.

Ok, renaming to Backend.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@MikeHolman

It's also less invasive (only a couple files vs. moving whole directory).

I stand by Backend being better but since lib => Lib the fewer-files-changed argument doesn't apply.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

I'm undecided on AsmJS* versus AsmJs*...

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

Updated checklist. I'll come back to this later.

@MikeHolman
Copy link
Contributor

@dilijev Yeah, you're right, I only noticed the lib->Lib change after. Also, I think AsmJs is better, and it's how we use it in most of our codebase.

@nojvek
Copy link

nojvek commented Feb 12, 2016

thanks for driving this

@jianchun
Copy link
Author

Updated checklist. I'll come back to this later.

@dilijev Thanks for looking! It is still hard to keep track. The list was created on an older version and some comments no longer apply.

@jianchun
Copy link
Author

Do we know how Windows machines will handle this/what (if anything) people will need to do to merge their changes after this goes through? On StackOverflow, the results I'm seeing for this topic are pretty scary.

I just performed a mock merge to linux, WebAssembly and JsRTDebugging. All went with no trouble! (WebAssembly added some files to lib/... and those new files remain under lowercase lib. Needs some updates after merging.)

BTW, Lib/Parser seems inherited some code all with lowercase file names which I left touched. You can browse them here: https://github.com/jianchun/ChakraCore/tree/case/Lib/Parser. Let me know if you think we should refresh them too.

Also I didn't touch bin in order to control this change size. (bin/ch looks fine on Linux.)

@MikeHolman
Copy link
Contributor

@jianchun, awesome, thanks for verifying! Definitely puts my mind at ease.

Skimmed through the rest of the list and it lgtm.

@jianchun
Copy link
Author

@MikeHolman Thank you! Could you please also try to merge it to your feature branch, to double test and just in case? You can simply merge https://github.com/jianchun/ChakraCore.git, case branch.

@jianchun
Copy link
Author

@dilijev I read your current list and here are some replies:

  • Jsrt, BailOut are in the same category as OpCode -- Majority of our code is using that form. e.g. JsrtContext, JsrtRuntime, JsrtThreadService, ..., BailOutKind, BailOutNames, BailOutRecord...
  • Jsrt/ChakraCommon.h is a public JSRT header, included by ChakraCore.h. So yes, that is its right place.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@MikeHolman after sleeping on it I also agree AsmJs is better.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@jianchun Sounds good. I'll update the list to mark those items as resolved.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

Here's the filtered list of everything I haven't marked off yet:

  • ...
    • hashfunc.cpp HashFunc.cpp // there are some recommendations not to use abbreviations like Func but since we all know what it means, it seems fine
    • cfglogger.h CFGLogger.h // Cfg instead of CFG
    • cfglogger.cpp CFGLogger.cpp // Cfg
  • lib/Backend => Lib/BackEnd // Backend should not change.
  • lib/Backend/i386 => Lib/BackEnd/i386
  • lib/Backend => Lib/BackEnd
    • LowerMDSharedSimd128.cpp LowerMDSharedSIMD128.cpp // keep Simd
  • lib/Backend/arm => Lib/BackEnd/arm
  • lib/Backend => Lib/BackEnd
    • Chakra.Backend.vcxproj.filters Chakra.BackEnd.vcxproj.filters // keep Backend
  • lib/Backend/amd64 => Lib/BackEnd/amd64
  • lib/Backend/arm64 => Lib/BackEnd/arm64
  • lib/Backend => Lib/BackEnd
    • Chakra.Backend.vcxproj Chakra.BackEnd.vcxproj // keep Backend
    • SimdOps.h SIMDOps.h // keep Simd
    • AsmJSBytecodeGenerator.h AsmJsByteCodeGenerator.h // in filenames we see more ByteCode than Bytecode (these are the only two instances of Bytecode I can see). 'git grep ... | wc' shows that there are 145 lines containing Bytecode and 2552 lines containing ByteCode. We should make it an item to refactor the instances of Bytecode to ByteCode so everything is consistent.
    • SIMDfloat64x2OperationX86X64.cpp SIMDFloat64x2OperationX86X64.cpp // change to Simd
    • SIMDUInt32x4Operation.cpp SIMDUint32x4Operation.cpp // change to Simd
    • AsmJsBuiltinNames.h AsmJsBuiltInNames.h // this is another instance where we are inconsistent across filenames and source -- in both cases about half and half
  • lib/Runtime/Language/arm => Lib/Runtime/Language/arm // did you mean to keep this as 'arm' and not 'ARM'?
  • lib/Runtime/Language/amd64 => Lib/Runtime/Language/amd64 `// did you mean to keep this as 'amd64' and not 'AMD64'?
    • SIMDUInt32x4OperationX86X64.cpp SIMDUint32x4OperationX86X64.cpp // Simd
    • SIMDUInt32x4Operation.h SIMDUint32x4Operation.h // Simd
    • SIMDUInt32x4Lib.h SIMDUint32x4Lib.h
    • SimdLib.h SIMDLib.h // Simd
    • SIMDUInt32x4Lib.cpp SIMDUint32x4Lib.cpp // Simd
    • JavascriptSIMDUInt32x4.h JavascriptSIMDUint32x4.h // Simd
  • lib/Runtime/Library/amd64 => Lib/Runtime/Library/amd64
    • JavascriptSIMDUInt32x4.cpp JavascriptSIMDUint32x4.cpp
    • OpCodesSimd.h OpCodesSIMD.h // Simd
    • byteCodeCacheReleaseFileVersion.h ByteCodeCacheReleaseFILEVersion.h // keep File

@MikeHolman
Copy link
Contributor

@jianchun Yup, tried on my big branches and merge seems ok. Only issue I'm seeing is with my new projects still referring to "lib", which I will have to fix up (as you noted).

I also tried adding a new file, since name on Windows file system "lib" didn't get renamed to "Lib". When unstaged it appears listed as untracked file "lib/asdf.txt", but once staged it turns into added file "Lib/asdf.txt", so git seems to have enough understanding and compensates appropriately.

@jianchun
Copy link
Author

@MikeHolman Thanks for verification!
@dilijev Cfg, Simd, Backend were done. i386, amd64, arm, arm64 seems chosen at many places. I'm personally fine with them.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@MikeHolman @jianchun looks like it will be fairly smooth

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@jianchun remaining list of concerns

  • hashfunc.cpp HashFunc.cpp // there are some recommendations not to use abbreviations like Func but since we all know what it means, it seems fine
  • AsmJSBytecodeGenerator.h AsmJsByteCodeGenerator.h // in filenames we see more ByteCode than Bytecode (these are the only two instances of Bytecode I can see). 'git grep ... | wc' shows that there are 145 lines containing Bytecode and 2552 lines containing ByteCode. We should make it an item to refactor the instances of Bytecode to ByteCode so everything is consistent.
  • AsmJsBuiltinNames.h AsmJsBuiltInNames.h // (Builtin versus BuiltIn) this is another instance where we are inconsistent across filenames and source -- in both cases about half and half
  • byteCodeCacheReleaseFileVersion.h ByteCodeCacheReleaseFILEVersion.h // keep 'File'

@jianchun
Copy link
Author

@dilijev Thanks for looking! ByteCode and File are already addressed in latest commit and in PR message. BuiltIn usage is indeed inconsistent.

@dilijev
Copy link
Contributor

dilijev commented Feb 12, 2016

@jianchun Sounds good. Looks like most things are resolved. On the split usage, I think we should prefer ByteCode. However, Builtin versus BuiltIn is not as clear. I think builtin as a word is less awkward because the alternative is a hyphenated built-in.

The terminology and precedent also seems to be split down the middle. In this case I'm in favor of just making the minimal changes to make it work because there's no need to be more disruptive than necessary.

We had a mix of inconsistent file name styles. This creates problems on
Linux as we had to modify source code includes to the same casing as real
file names. This change attempts rename (most) /lib/ files to CamelCase.

```
lib/Backend                         =>  Lib/Backend

     BackEnd.cpp                             Backend.cpp
     BackEnd.h                               Backend.h
     BackEndOpcodeAttrAsmJs.cpp              BackendOpCodeAttrAsmJs.cpp
     BackEndOpcodeAttrAsmJs.h                BackendOpCodeAttrAsmJs.h
     BackEndOpCodeList.h                     BackendOpCodeList.h
     CodegenNumberAllocator.cpp              CodeGenNumberAllocator.cpp
     GlobOptBailout.cpp                      GlobOptBailOut.cpp
     SCCLiveness.cpp                         SccLiveness.cpp
     SCCLiveness.h                           SccLiveness.h


lib/Backend/amd64                   =>  Lib/Backend/amd64

     MdOpcodes.h                             MdOpCodes.h


lib/Backend/arm                     =>  Lib/Backend/arm

     MdOpcodes.h                             MdOpCodes.h


lib/Backend/arm64                   =>  Lib/Backend/arm64

     MdOpcodes.h                             MdOpCodes.h


lib/Backend/i386                    =>  Lib/Backend/i386

     MdOpcodes.h                             MdOpCodes.h


lib/common                          =>  Lib/Common

     BackEndAPI.h                            BackendApi.h
     commoninl.h                             CommonInl.h
     resource.h                              Resource.h


lib/common/common                   =>  Lib/Common/Common

     cfglogger.cpp                           CfgLogger.cpp
     cfglogger.h                             CfgLogger.h
     GetCurrentFrameID.h                     GetCurrentFrameId.h
     int16math.h                             Int16Math.h
     SmartFPUControl.cpp                     SmartFpuControl.cpp
     SmartFPUControl.h                       SmartFpuControl.h


lib/common/core                     =>  Lib/Common/Core

     api.h                                   Api.h
     AutoFILE.h                              AutoFile.h


lib/common/DataStructures           =>  Lib/Common/DataStructures

     comparer.h                              Comparer.h
     dictionary.h                            Dictionary.h
     Dlist.h                                 DList.h
     growingArray.cpp                        GrowingArray.cpp
     growingArray.h                          GrowingArray.h
     interval.h                              Interval.h
     list.h                                  List.h
     stack.h                                 Stack.h


lib/common/Exceptions               =>  Lib/Common/Exceptions

     reporterror.cpp                         ReportError.cpp
     reporterror.h                           ReportError.h


lib/common/Memory                   =>  Lib/Common/Memory

     collectionstate.h                       CollectionState.h
     heapblock.inl                           HeapBlock.inl
     heapbucket.cpp                          HeapBucket.cpp
     heapbucket.h                            HeapBucket.h
     heapbucket.inl                          HeapBucket.inl
     heapinfo.cpp                            HeapInfo.cpp
     heapinfo.h                              HeapInfo.h
     leakreport.cpp                          LeakReport.cpp
     leakreport.h                            LeakReport.h


lib/common/util                     =>  Lib/Common/Util

     pinned.cpp                              Pinned.cpp
     pinned.h                                Pinned.h


lib/jsrt                            =>  Lib/Jsrt

     chakracommon.h                          ChakraCommon.h
     jsrtcontext.cpp                         JsrtContext.cpp
     jsrtcontext.h                           JsrtContext.h
     jsrtExternalObject.cpp                  JsrtExternalObject.cpp
     jsrtExternalObject.h                    JsrtExternalObject.h
     jsrtinternal.h                          JsrtInternal.h
     jsrtRuntime.cpp                         JsrtRuntime.cpp
     jsrtRuntime.h                           JsrtRuntime.h
     jsrtThreadService.cpp                   JsrtThreadService.cpp
     jsrtThreadService.h                     JsrtThreadService.h


lib/Parser                          =>  Lib/Parser

     alloc.cpp                               Alloc.cpp
     alloc.h                                 Alloc.h
     hash.cpp                                Hash.cpp
     hash.h                                  Hash.h
     hashfunc.cpp                            HashFunc.cpp
     jsscan.js                               JsScan.js
     parse.cpp                               Parse.cpp
     parse.h                                 Parse.h
     regcodes.h                              RegCodes.h
     RegexOpcodes.h                          RegexOpCodes.h
     RegexRunTime.cpp                        RegexRuntime.cpp
     RegexRunTime.h                          RegexRuntime.h
     scan.cpp                                Scan.cpp
     scan.h                                  Scan.h


lib/Runtime/Base                    =>  Lib/Runtime/Base

     scriptcontextbase.h                     ScriptContextBase.h
     ThreadContextTLSEntry.cpp               ThreadContextTlsEntry.cpp
     ThreadContextTLSEntry.h                 ThreadContextTlsEntry.h
     threadservicewrapper.h                  ThreadServiceWrapper.h


lib/Runtime/ByteCode                =>  Lib/Runtime/ByteCode

     AsmJSByteCodeDumper.cpp                 AsmJsByteCodeDumper.cpp
     AsmJSByteCodeDumper.h                   AsmJsByteCodeDumper.h
     BackEndOpcodeAttr.cpp                   BackendOpCodeAttr.cpp
     BackEndOpcodeAttr.h                     BackendOpCodeAttr.h
     ByteCodeAPI.h                           ByteCodeApi.h
     byteCodeCacheReleaseFileVersion.h       ByteCodeCacheReleaseFileVersion.h
     Opcodes.cpp                             OpCodes.cpp


lib/Runtime/Language                =>  Lib/Runtime/Language

     asmjs.cpp                               AsmJs.cpp
     AsmJS.h                                 AsmJs.h
     AsmJsBuiltinNames.h                     AsmJsBuiltInNames.h
     AsmJSBytecodeGenerator.cpp              AsmJsByteCodeGenerator.cpp
     AsmJSBytecodeGenerator.h                AsmJsByteCodeGenerator.h
     AsmJSCodeGenerator.cpp                  AsmJsCodeGenerator.cpp
     AsmJSCodeGenerator.h                    AsmJsCodeGenerator.h
     AsmJSEncoder.cpp                        AsmJsEncoder.cpp
     AsmJSEncoder.h                          AsmJsEncoder.h
     AsmJSEncoder.inl                        AsmJsEncoder.inl
     AsmJSEncoderHandler.inl                 AsmJsEncoderHandler.inl
     AsmJSJitTemplate.h                      AsmJsJitTemplate.h
     AsmJSLink.cpp                           AsmJsLink.cpp
     AsmJSLink.h                             AsmJsLink.h
     AsmJSModule.cpp                         AsmJsModule.cpp
     AsmJSModule.h                           AsmJsModule.h
     AsmJSTypes.cpp                          AsmJsTypes.cpp
     AsmJSTypes.h                            AsmJsTypes.h
     AsmJSUtils.cpp                          AsmJsUtils.cpp
     AsmJSUtils.h                            AsmJsUtils.h
     SIMDBool16x8Operation.cpp               SimdBool16x8Operation.cpp
     SIMDBool16x8Operation.h                 SimdBool16x8Operation.h
     SIMDBool16x8OperationX86X64.cpp         SimdBool16x8OperationX86X64.cpp
     SIMDBool32x4Operation.cpp               SimdBool32x4Operation.cpp
     SIMDBool32x4Operation.h                 SimdBool32x4Operation.h
     SIMDBool32x4OperationX86X64.cpp         SimdBool32x4OperationX86X64.cpp
     SIMDBool8x16Operation.cpp               SimdBool8x16Operation.cpp
     SIMDBool8x16Operation.h                 SimdBool8x16Operation.h
     SIMDBool8x16OperationX86X64.cpp         SimdBool8x16OperationX86X64.cpp
     SIMDFloat32x4Operation.cpp              SimdFloat32x4Operation.cpp
     SIMDFloat32x4Operation.h                SimdFloat32x4Operation.h
     SIMDfloat32x4OperationX86X64.cpp        SimdFloat32x4OperationX86X64.cpp
     SIMDFloat64x2Operation.cpp              SimdFloat64x2Operation.cpp
     SIMDFloat64x2Operation.h                SimdFloat64x2Operation.h
     SIMDfloat64x2OperationX86X64.cpp        SimdFloat64x2OperationX86X64.cpp
     SIMDInt16x8Operation.cpp                SimdInt16x8Operation.cpp
     SIMDInt16x8Operation.h                  SimdInt16x8Operation.h
     SIMDInt16x8OperationX86X64.cpp          SimdInt16x8OperationX86X64.cpp
     SIMDInt32x4Operation.cpp                SimdInt32x4Operation.cpp
     SIMDInt32x4Operation.h                  SimdInt32x4Operation.h
     SIMDInt32x4OperationX86X64.cpp          SimdInt32x4OperationX86X64.cpp
     SIMDInt8x16Operation.cpp                SimdInt8x16Operation.cpp
     SIMDInt8x16Operation.h                  SimdInt8x16Operation.h
     SIMDInt8x16OperationX86X64.cpp          SimdInt8x16OperationX86X64.cpp
     SIMDUint16x8Operation.cpp               SimdUint16x8Operation.cpp
     SIMDUint16x8Operation.h                 SimdUint16x8Operation.h
     SIMDUint16x8OperationX86X64.cpp         SimdUint16x8OperationX86X64.cpp
     SIMDUInt32x4Operation.cpp               SimdUint32x4Operation.cpp
     SIMDUInt32x4Operation.h                 SimdUint32x4Operation.h
     SIMDUInt32x4OperationX86X64.cpp         SimdUint32x4OperationX86X64.cpp
     SIMDUint8x16Operation.cpp               SimdUint8x16Operation.cpp
     SIMDUint8x16Operation.h                 SimdUint8x16Operation.h
     SIMDUint8x16OperationX86X64.cpp         SimdUint8x16OperationX86X64.cpp
     SIMDUtils.cpp                           SimdUtils.cpp
     SIMDUtils.h                             SimdUtils.h


lib/Runtime/Language/amd64          =>  Lib/Runtime/Language/amd64

     AsmJSJitTemplate.cpp                    AsmJsJitTemplate.cpp
     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h
     stackframe.inl                          StackFrame.inl


lib/Runtime/Language/arm            =>  Lib/Runtime/Language/arm

     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h


lib/Runtime/Language/arm64          =>  Lib/Runtime/Language/arm64

     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h


lib/Runtime/Language/i386           =>  Lib/Runtime/Language/i386

     AsmJSJitTemplate.cpp                    AsmJsJitTemplate.cpp
     stackframe.cpp                          StackFrame.cpp
     stackframe.h                            StackFrame.h


lib/Runtime/Library                 =>  Lib/Runtime/Library

     dataview.cpp                            DataView.cpp
     dataview.h                              DataView.h
     JavascriptSIMDBool16x8.cpp              JavascriptSimdBool16x8.cpp
     JavascriptSIMDBool16x8.h                JavascriptSimdBool16x8.h
     JavascriptSIMDBool32x4.cpp              JavascriptSimdBool32x4.cpp
     JavascriptSIMDBool32x4.h                JavascriptSimdBool32x4.h
     JavascriptSIMDBool8x16.cpp              JavascriptSimdBool8x16.cpp
     JavascriptSIMDBool8x16.h                JavascriptSimdBool8x16.h
     JavascriptSIMDFloat32x4.cpp             JavascriptSimdFloat32x4.cpp
     JavascriptSIMDFloat32x4.h               JavascriptSimdFloat32x4.h
     JavascriptSIMDFloat64x2.cpp             JavascriptSimdFloat64x2.cpp
     JavascriptSIMDFloat64x2.h               JavascriptSimdFloat64x2.h
     JavascriptSIMDInt16x8.cpp               JavascriptSimdInt16x8.cpp
     JavascriptSIMDInt16x8.h                 JavascriptSimdInt16x8.h
     JavascriptSIMDInt32x4.cpp               JavascriptSimdInt32x4.cpp
     JavascriptSIMDInt32x4.h                 JavascriptSimdInt32x4.h
     JavascriptSIMDInt8x16.cpp               JavascriptSimdInt8x16.cpp
     JavascriptSIMDInt8x16.h                 JavascriptSimdInt8x16.h
     JavascriptSIMDUint16x8.cpp              JavascriptSimdUint16x8.cpp
     JavascriptSIMDUint16x8.h                JavascriptSimdUint16x8.h
     JavascriptSIMDUInt32x4.cpp              JavascriptSimdUint32x4.cpp
     JavascriptSIMDUInt32x4.h                JavascriptSimdUint32x4.h
     JavascriptSIMDUint8x16.cpp              JavascriptSimdUint8x16.cpp
     JavascriptSIMDUint8x16.h                JavascriptSimdUint8x16.h
     javascripttypednumber.cpp               JavascriptTypedNumber.cpp
     javascripttypednumber.h                 JavascriptTypedNumber.h
     moduleroot.cpp                          ModuleRoot.cpp
     moduleroot.h                            ModuleRoot.h
     SIMDBool16x8Lib.cpp                     SimdBool16x8Lib.cpp
     SIMDBool16x8Lib.h                       SimdBool16x8Lib.h
     SIMDBool32x4Lib.cpp                     SimdBool32x4Lib.cpp
     SIMDBool32x4Lib.h                       SimdBool32x4Lib.h
     SIMDBool8x16Lib.cpp                     SimdBool8x16Lib.cpp
     SIMDBool8x16Lib.h                       SimdBool8x16Lib.h
     SIMDFloat32x4Lib.cpp                    SimdFloat32x4Lib.cpp
     SIMDFloat32x4Lib.h                      SimdFloat32x4Lib.h
     SIMDFloat64x2Lib.cpp                    SimdFloat64x2Lib.cpp
     SIMDFloat64x2Lib.h                      SimdFloat64x2Lib.h
     SIMDInt16x8Lib.cpp                      SimdInt16x8Lib.cpp
     SIMDInt16x8Lib.h                        SimdInt16x8Lib.h
     SIMDInt32x4Lib.cpp                      SimdInt32x4Lib.cpp
     SIMDInt32x4Lib.h                        SimdInt32x4Lib.h
     SIMDInt8x16Lib.cpp                      SimdInt8x16Lib.cpp
     SIMDInt8x16Lib.h                        SimdInt8x16Lib.h
     SIMDUint16x8Lib.cpp                     SimdUint16x8Lib.cpp
     SIMDUint16x8Lib.h                       SimdUint16x8Lib.h
     SIMDUInt32x4Lib.cpp                     SimdUint32x4Lib.cpp
     SIMDUInt32x4Lib.h                       SimdUint32x4Lib.h
     SIMDUint8x16Lib.cpp                     SimdUint8x16Lib.cpp
     SIMDUint8x16Lib.h                       SimdUint8x16Lib.h
     typedArrayEnumerator.cpp                TypedArrayEnumerator.cpp
     typedArrayEnumerator.h                  TypedArrayEnumerator.h


lib/Runtime/Library/amd64           =>  Lib/Runtime/Library/amd64

     javascriptfunctiona.asm                 JavascriptFunctionA.asm


lib/Runtime/Library/InJavascript    =>  Lib/Runtime/Library/InJavascript

     intl.js.bc.32b.h                        Intl.js.bc.32b.h
     intl.js.bc.64b.h                        Intl.js.bc.64b.h
```
@dilijev
Copy link
Contributor

dilijev commented Feb 13, 2016

LGTM. Signing off.

@chakrabot chakrabot merged commit 4e05cc2 into chakra-core:master Feb 13, 2016
@jianchun
Copy link
Author

@dilijev Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants