Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChakraCore 2018-06 security updates #5298

Merged
merged 4 commits into from
Jun 12, 2018
Merged

ChakraCore 2018-06 security updates #5298

merged 4 commits into from
Jun 12, 2018

Conversation

leirocks
Copy link
Contributor

No description provided.

@MSLaguana
Copy link
Contributor

Can you please bump the version in https://github.com/Microsoft/ChakraCore/blob/master/lib/Common/ChakraCoreVersion.h#L20 and https://github.com/Microsoft/ChakraCore/blob/master/Build/NuGet/.pack-version

@MSLaguana
Copy link
Contributor

@dotnet-bot test OSX _no_jit_shared_osx_osx_test please
@dotnet-bot test OSX static_osx_osx_debug please
@dotnet-bot test OSX static_osx_osx_release please
@dotnet-bot test OSX static_osx_osx_test please

@MSLaguana
Copy link
Contributor

The OSX builds look like they are an issue with our CI; locally OSX builds fine with this change according to @sethbrenith so I think we should just get this in for now.

@MSLaguana
Copy link
Contributor

I guess I can't retroactively get the CI to ignore those phases or mark them as skipped.

@MSLaguana
Copy link
Contributor

@dotnet-bot test OSX _no_jit_shared_osx_osx_test please
@dotnet-bot test OSX static_osx_osx_debug please
@dotnet-bot test OSX static_osx_osx_release please
@dotnet-bot test OSX static_osx_osx_test please

@chakrabot chakrabot merged commit 1b4f8dc into chakra-core:release/1.8 Jun 12, 2018
chakrabot pushed a commit that referenced this pull request Jun 12, 2018
@leirocks
[MERGE #5298 @leirocks] ChakraCore 2018-06 security updates
c325cf3 
Merge pull request #5298 from leirocks:servicing/1806_1.8
chakrabot pushed a commit that referenced this pull request Jun 12, 2018
@leirocks
[1.8>1.9] [MERGE #5298 @leirocks] ChakraCore 2018-06 security updates
4707cbf 
Merge pull request #5298 from leirocks:servicing/1806_1.8
chakrabot pushed a commit that referenced this pull request Jun 12, 2018
@leirocks
[1.9>master] [1.8>1.9] [MERGE #5298 @leirocks] ChakraCore 2018-06 sec…
058c1cd 
…urity updates

Merge pull request #5298 from leirocks:servicing/1806_1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meg-gupta meg-gupta meg-gupta approved these changes

@MSLaguana MSLaguana MSLaguana approved these changes

@MikeHolman MikeHolman MikeHolman approved these changes

@pleath pleath Awaiting requested review from pleath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leirocks @MSLaguana @MikeHolman @meg-gupta @chakrabot @pleath