Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++20/DR] Fix compile error for equality in rewrite expressions #6863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QuellaZhang
Copy link

After the MSVC team implemented P2468R2 The Equality Operator You Are Looking For, we got an error compiling ChakraCore with /std:c++latest on MSVC, now it is fixed.

Error message:
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(70,16): error C2666: '_SIMDValue::operator ==': overloaded functions have similar conversions
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(48,10): note: could be 'bool _SIMDValue::operator ==(const _SIMDValue &)'
C:\Program Files (x86)\Windows Kits\10\include\10.0.22618.0\shared\guiddef.h(192,15): note: or 'bool operator ==(const GUID &,const GUID &)'
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(48,10): note: or 'bool _SIMDValue::operator ==(const _SIMDValue &)' [synthesized expression 'y == x']
C:\Program Files (x86)\Windows Kits\10\include\10.0.22618.0\shared\guiddef.h(192,15): note: or 'bool operator ==(const GUID &,const GUID &)' [synthesized expression 'y == x']
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(70,16): note: while trying to match the argument list '(_SIMDValue, _SIMDValue)'

@ppenzin
Copy link
Member

ppenzin commented Dec 28, 2022

Sorry for taking so long to get back to this. Thank you for the PR, I am trying to re-run pipelines to see why Test build failed.

@ppenzin
Copy link
Member

ppenzin commented Dec 30, 2022

@QuellaZhang do yo mind if I rebase it on top of latest changes? That would force-change your fork. Or can you rebase it yourself? I'm not sure why builds are not re-running (history is gone), maybe that would restart them.

Then change looks reasonable overall, though we need to try to get to the bottom of CI failures. On a similar note, can you sign contribution agreement? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants