-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): add id props and improve state exposition #918
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ded7c59
to
53e7c13
Compare
"id": {
"type": "string",
"isRequired": true,
"description": "The unique identifier of the machine."
}, The generated types, in this case the accordion are not 100% correct. The export type UseAccordionProps = Optional<accordion.Context, 'id'> |
ea038ec
to
669ac2f
Compare
d0da4be
to
24629c7
Compare
Hey ya'll. Just wondering if this PR is taking into account the recent release of Vue 3.3 and specifically being able to use imported types in SFC? I just upgraded and the exported types from Ark don't seem to be compatible for some reason. Just curious as this could be a huge time saver as I wouldn't need to re-write all of the props in my custom components, but just import an extend the ones from Ark instead. |
Hey @jiblett1000 This PR is not related, as the SFC types are only available under SFC's. We use TSX to build our Vue components so we don't have the same issues as we can already use Typescript how we want. The exported types are pure typescript so you can reuse them in your own Could you elaborate a little bit more on what you mean by "exportes types don't seem compatible for some reason", what errors do you have etc? Thanks |
Hey @Shyrro I'm happy to create an issue for this if need be. This is where I'm importing / using the type: import type { NumberInputProps } from "@ark-ui/vue";
interface Props {
label: string;
id?: string;
paddingRight?: number;
paddingLeft?: number;
}
const props = defineProps<NumberInputProps & Props>(); I modified an existing stackblitz to show the error.... although, I'm getting a different error there than I am locally. https://stackblitz.com/edit/nuxt-starter-3jzcrb?file=components%2FChildDialog.vue |
BREAKING CHANGE: Update exposed context types and remove unnecessary expose calls Signed-off-by: Shyrro <zsahmane@gmail.com>
Signed-off-by: Shyrro <zsahmane@gmail.com>
9bbb142
to
b435ac6
Compare
BREAKING CHANGE: Update exposed context types and remove unnecessary expose calls
This PR contains :
v-slot
for needed components #913 , [Menu] [Vue]: slot props #905 )