-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support animationStyle
composition
#2701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 8adfb42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LFG! I'm ready to use this 🔥 |
segunadebayo
changed the title
feat: motion styles and better keyframe defaults
feat: support animotion styles
Dec 8, 2024
segunadebayo
changed the title
feat: support animotion styles
feat: support animation styles
Dec 8, 2024
segunadebayo
changed the title
feat: support animation styles
feat: support Dec 8, 2024
animationStyle
mixin
segunadebayo
changed the title
feat: support
feat: support Dec 8, 2024
animationStyle
mixinanimationStyle
composition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is a spin-off from my work on Chakra. Let's introduce a new "mixin" called motion styles. The idea is to pair them with text styles and layer styles to create this three-part mixin that can make your styles a lot cleaner.
Motion styles focus solely on animations, allowing you to orchestrate animation properties.
Here's a good example of this:
With that defined, I can use it in my recipe or css like so:
This feature will allow us to lean in towards CSS for animations rather than JS. Composing animation names is a powerful feature we should encourage consumers to use.