Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flex basis tokens #2855

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

adbutterfield
Copy link
Contributor

@adbutterfield adbutterfield commented Sep 9, 2024

📝 Description

Since flex-basis specifies a width, it should use sizes tokens.

This PR updates the type of the Flex utility to allow using sizes tokens instead of spacing tokens.

⛳️ Current behavior (updates)

Type does not allow using sizes tokens for basis prop on Flex utility, but it does allow for using spacing tokens.

🚀 New behavior

Type now allows using sizes tokens for basis prop on Flex utility, and does not allow using spacing tokens.

💣 Is this a breaking change (Yes/No):

Technically no? You could always @ts-ignore any place where you're currently passing a spacing token to basis.

📝 Additional Information

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 0c18b1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@pandacss/preset-base Patch
@pandacss/generator Patch
@pandacss/config Patch
@pandacss/node Patch
@pandacss/parser Patch
@pandacss/dev Patch
@pandacss/studio Patch
@pandacss/astro-plugin-studio Patch
@pandacss/postcss Patch
@pandacss/core Patch
@pandacss/extractor Patch
@pandacss/is-valid-prop Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-open-props Patch
@pandacss/preset-panda Patch
@pandacss/shared Patch
@pandacss/token-dictionary Patch
@pandacss/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-playground ✅ Ready (Inspect) Visit Preview Sep 9, 2024 5:10am
panda-studio ✅ Ready (Inspect) Visit Preview Sep 9, 2024 5:10am

Copy link

vercel bot commented Sep 9, 2024

@adbutterfield is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@segunadebayo
Copy link
Member

Thanks @adbutterfield

@segunadebayo segunadebayo merged commit b7ed157 into chakra-ui:main Sep 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants