Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GitHub backup token input is limited to 40 characters #122

Closed
1 task done
frogamic opened this issue Jul 16, 2024 · 6 comments
Closed
1 task done

[Bug] GitHub backup token input is limited to 40 characters #122

frogamic opened this issue Jul 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@frogamic
Copy link

What happened?

The input field for token in GitHub backup screen is limited to 40 characters.
image
This causes fine-grained personal access tokens to be trimmed and don't work, since that token is longer, eg github_pat_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Note that fine-grained personal access token is supported by the file contents api as linked from the github backup page: https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28#create-or-update-file-contents

Platform

All

Device Info

No response

Which game server is related to this issue? (Optional)

No response

App Version

2.5.10 (971) - 9381d2

Checklist

Relevant log output

No response

@frogamic frogamic added the bug Something isn't working label Jul 16, 2024
@narumi147
Copy link
Member

Does the fine-grained PAT have fixed length or any pattern to validate?

@frogamic
Copy link
Author

I cannot find any official conclusive doco on the access token format or length, but having generated a few tokens they seem to be 93 characters and start with github_pat_

@narumi147
Copy link
Member

sorry forgot this issue, does 93 chars include the github_pat_ prefix

@frogamic
Copy link
Author

frogamic commented Aug 5, 2024

Yes, 93 characters includes the github_pat_ prefix

narumi147 added a commit that referenced this issue Aug 5, 2024
@narumi147
Copy link
Member

try beta when new build finished

@frogamic
Copy link
Author

frogamic commented Aug 8, 2024

Thanks, it's working perfectly now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants