Added Avail DA to Rollkit #2
Conversation
|
Hi @aterentic-ethernal |
I pulled the code from upstream main that might be the reason |
| // CheckBlockAvailability queries DA layer to check data availability of block. | ||
| func (c *DataAvailabilityLayerClient) CheckBlockAvailability(ctx context.Context, dataLayerHeight uint64) da.ResultCheckBlock { | ||
|
|
||
| blockNumber := dataLayerHeight |
There was a problem hiding this comment.
Why new variable?
There was a problem hiding this comment.
@akhilkumarpilli ,datalayerheight and blocknumber are two different fields but currently we are considering datalayerheight as blocknumber that's why I have taken a new variable.If there is no necessity of new variable,I'll remove it. Please suggest
There was a problem hiding this comment.
For now, you can remove it.
| genesisHash, err := api.RPC.Chain.GetBlockHash(0) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
What if genesis height is different? Will it always be zero?
No description provided.