Skip to content

Commit

Permalink
syscall: enable TestSyscallNoError on all Linux 32-bit architectures
Browse files Browse the repository at this point in the history
Check the size of uintptr instead of listing GOARCHes explicitly. This
will make the test also run on linux/mips{,le}.

Change-Id: I649f15d293002afc1360b1913910202c3e5188b7
Reviewed-on: https://go-review.googlesource.com/135715
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
tklauser committed Sep 17, 2018
1 parent 623c772 commit 5eec237
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/syscall/syscall_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"syscall"
"testing"
"time"
"unsafe"
)

// chtmpdir changes the working directory to a new temporary directory and
Expand Down Expand Up @@ -294,7 +295,7 @@ func TestSyscallNoError(t *testing.T) {
// On Linux there are currently no syscalls which don't fail and return
// a value larger than 0xfffffffffffff001 so we could test RawSyscall
// vs. RawSyscallNoError on 64bit architectures.
if runtime.GOARCH != "386" && runtime.GOARCH != "arm" {
if unsafe.Sizeof(uintptr(0)) != 4 {
t.Skip("skipping on non-32bit architecture")
}

Expand Down

0 comments on commit 5eec237

Please sign in to comment.