解决ios系统无法显示汉字动画的问题 #130
Merged
解决ios系统无法显示汉字动画的问题 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanind
reviewed
Jul 31, 2019
| @@ -20,7 +20,8 @@ HanziWriterRenderer.prototype._animationFrame = function(func) { | |||
|
|
|||
| ctx.save(); | |||
| ctx.translate(this._positioner.xOffset, this._positioner.height - this._positioner.yOffset); | |||
| ctx.scale(this._positioner.scale, -1 * this._positioner.scale); | |||
| ctx.transform(1, 0, 0, -1, 0, 0); | |||
| ctx.scale(this._positioner.scale, this._positioner.scale); | |||
There was a problem hiding this comment.
looks like the linter is complaining that there's too many spaces here
chanind
requested changes
Jul 31, 2019
There was a problem hiding this comment.
I can't verify if this fixes the miniprogram iOS issue, but it doesn't appear to break anything at least! Just 2 minor things to get this merged:
- remove the extra space on line 24 before
this - run
yarn test --update-snapshotto update tests
Thanks for submitting this PR!
|
I verified it on the ipad 、iphone 6s and an Android device with the WeChat Mini Program，it works well. |
chanind
approved these changes
Aug 1, 2019
chanind
added a commit
that referenced
this pull request
Aug 1, 2019
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121