Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors #88

Merged
merged 6 commits into from
Oct 1, 2018
Merged

Update colors #88

merged 6 commits into from
Oct 1, 2018

Conversation

chanind
Copy link
Owner

@chanind chanind commented Oct 1, 2018

Closes #87

This PR adds an updateColor(colorName, newValue, options) method which can be used to tween colors on a running HanziWriter instance.

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #88 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   98.41%   98.46%   +0.05%     
==========================================
  Files          22       22              
  Lines         885      915      +30     
  Branches      147      157      +10     
==========================================
+ Hits          871      901      +30     
  Misses         14       14
Impacted Files Coverage Δ
src/characterActions.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️
src/renderers/UserStrokeRenderer.js 100% <100%> (ø) ⬆️
src/renderers/CharacterRenderer.js 100% <100%> (ø) ⬆️
src/HanziWriter.js 93.47% <100%> (+0.45%) ⬆️
src/RenderState.js 100% <100%> (ø) ⬆️
src/renderers/StrokeRenderer.js 100% <100%> (ø) ⬆️
src/renderers/HanziWriterRenderer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08114a...9ea9f0d. Read the comment docs.

@chanind chanind merged commit 4e38a21 into master Oct 1, 2018
@chanind chanind deleted the update-colors branch October 1, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants