Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @testing-library/react-hooks from dependencies #1108

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Jan 18, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Summary

  • react-hooks-testing-library(@testing-library/react-hooks)의 사용처를 제거합니다.
  • @testing-library/react-hooks 라이브러리를 제거합니다.

Details

  • @testing-library/react-hooks 대신 @testing-library/reactrenderHook을 사용하도록 합니다.
  • @testing-library/react-hooks deps를 제거합니다.

Breaking change or not (Yes/No)

No.

References

@Dogdriip Dogdriip added refactoring Issue or PR related to refactoring with no functional changes chore:deps Issue or PR related to dependencies labels Jan 18, 2023
@Dogdriip Dogdriip self-assigned this Jan 18, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

⚠️ No Changeset found

Latest commit: 623d117

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 72.75% // Head: 72.75% // No change to project coverage 👍

Coverage data is based on head (623d117) compared to base (44ea4f7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1108   +/-   ##
========================================
  Coverage    72.75%   72.75%           
========================================
  Files          362      362           
  Lines         4371     4371           
  Branches       852      852           
========================================
  Hits          3180     3180           
  Misses        1117     1117           
  Partials        74       74           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Dogdriip Dogdriip force-pushed the deps/testing-library-react branch from e8221fd to 623d117 Compare January 19, 2023 03:57
@Dogdriip Dogdriip marked this pull request as ready for review January 19, 2023 06:22
@Dogdriip Dogdriip merged commit eb803d1 into channel-io:next-v1 Jan 19, 2023
@Dogdriip Dogdriip deleted the deps/testing-library-react branch January 19, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore:deps Issue or PR related to dependencies refactoring Issue or PR related to refactoring with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants