Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yarnrc): add yarn plugin for validating yarn, node version #1220

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

Kanary159357
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

package.json에 engines를 통해 node와 yarn의 버젼을 지정해도, 실제 스크립트를 돌릴때 버젼에 대한 검증을 하지 않습니다.

이를 검증하는 yarn plugin을 추가합니다.

Details

yarn 3.2 미만의 버젼으로 bezier-react를 빌드시에 빌드가 깨지는 문제가 있습니다. 확인해본 결과 engines에 yarn 버젼이 3.4.1로 명시되어있음에도 불구하고 이를 검증하지 않아 휴먼 에러가 발생했습니다.

Yarn berry부터는 engines에 대한 validation이 yarn 내에서 이루어지지 않도록 변경되어 이를 돌려달라는 Yarn Berry에서의 Issue도 존재합니다.

Breaking change or not (Yes/No)

References

@Kanary159357 Kanary159357 added the chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code label Mar 21, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

⚠️ No Changeset found

Latest commit: 18e1d0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f01dd49) 77.61% compared to head (18e1d0c) 77.61%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1220   +/-   ##
========================================
  Coverage    77.61%   77.61%           
========================================
  Files          296      296           
  Lines         3815     3815           
  Branches       846      846           
========================================
  Hits          2961     2961           
  Misses         559      559           
  Partials       295      295           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kanary159357 Kanary159357 merged commit 985c935 into channel-io:next-v1 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants