Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to support React v18 as peer dependency #799

Conversation

inhibitor1217
Copy link
Contributor

Summary

react@^18.0.0 을 지원하도록 direct dependency 버전을 업데이트 합니다.

  • react-resize-detector: ^6.7.4 -> ^7.1.1
  • react-textarea-autosize: ^8.3.3 -> ^8.3.4

Details

  • 버전 업데이트로 인한 changelog는 체크 결과 문제 없이 마이그레이션 가능합니다.
  • @mdx-js/react는 v2부터 react v18을 지원합니다. 현재 사용중인 Storybook 6에서는 opt-in 기능으로 지원되고, 7버전부터 기본 지원된다고 합니다. (MDX2: Can't resolve '@mdx-js/react' storybookjs/storybook#18094)
    • Opt-in으로 적용해보았으나, mdx 쪽 문서에서도 breaking change를 바로잡아야 하는 부분이 많았습니다.
    • 따라서 이 문제는 나중에 해결하기로 하고, --legacy-peer-deps 옵션을 통해 업데이트합니다.

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

References

@inhibitor1217 inhibitor1217 added the chore:deps Issue or PR related to dependencies label May 25, 2022
@inhibitor1217 inhibitor1217 self-assigned this May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #799 (73ffec0) into next-v1 (6961d63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           next-v1     #799   +/-   ##
========================================
  Coverage    66.67%   66.67%           
========================================
  Files          192      192           
  Lines         2821     2821           
  Branches       775      775           
========================================
  Hits          1881     1881           
  Misses         820      820           
  Partials       120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6961d63...73ffec0. Read the comment docs.

Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-resize-detector 어제까지만 해도 업데이트가 안됐었는데... 오늘 됐나보네요

@inhibitor1217 inhibitor1217 merged commit 8395689 into channel-io:next-v1 May 26, 2022
@inhibitor1217 inhibitor1217 deleted the chore/bezier-react/deps/support-react-v18-peer branch May 26, 2022 06:14
@ch-builder
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next-v1.132 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore:deps Issue or PR related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants