Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary postgres req #2524

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

MDunitz
Copy link
Contributor

@MDunitz MDunitz commented May 27, 2022

Reviewers

Functional:


Changes

  • remove unnecessary postgres dependency

@MDunitz MDunitz requested a review from maniarathi May 27, 2022 18:49
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2524 (bc8f670) into main (de44739) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2524   +/-   ##
=======================================
  Coverage   71.64%   71.64%           
=======================================
  Files          94       94           
  Lines        6464     6464           
  Branches      738      738           
=======================================
  Hits         4631     4631           
  Misses       1757     1757           
  Partials       76       76           
Flag Coverage Δ
frontend 71.64% <ø> (ø)
javascript 71.64% <ø> (ø)
smokeTestAnnotations ?
unitTest 71.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de44739...bc8f670. Read the comment docs.

Copy link
Contributor

@maniarathi maniarathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This dependency appears to have been added in this PR when we added the DB for supporting annotations in the hosted version of cellxgene. That code is now split out into its own repo and there is no longer any additional need to support that DB in this version of cellxgene.

@MDunitz MDunitz merged commit f2bd6eb into main May 27, 2022
@MDunitz MDunitz deleted the dunitz/remove-dependency branch May 27, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants