Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All three vectors of OrientedPoint annotations have the same color #18

Open
uermel opened this issue Aug 26, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@uermel
Copy link

uermel commented Aug 26, 2024

In the precomputed line-based visualization of OrientedPoint annotations, all three lines have the same color.

The expected behavior is that the lines are colored by the principle axis they represent (with the same color scheme Neuroglancer uses for the global axes).

See example. Source run.
Screenshot:
image

@seankmartin
Copy link
Collaborator

seankmartin commented Sep 5, 2024

Hi @uermel and @manasaV3,

This is bug is caused by the oriented points using the regular points shader. They should instead by using the OrientedPointsShaderBuilder, which result in the link above looking like this instead new link:

image

I think the most likely cause is that the JSON state generation for this layer in the portal backend is using the json.generator.AnnotationJSONGenerator class instead of the intended json.OrientedPointAnnotationJSONGenerator class. The oriented point generator is a subclass of the annotation generator, so hopefully it shouldn't be an issue to swap them - but if something is blocking that please let us know! This would mean calling state_generator.generate_oriented_point_layer instead of state_generator.generate_point_layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants