Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oriented point rendering in neuroglancer #1059

Open
Tracked by #1058
manasaV3 opened this issue Aug 21, 2024 · 5 comments
Open
Tracked by #1058

Update oriented point rendering in neuroglancer #1059

manasaV3 opened this issue Aug 21, 2024 · 5 comments
Labels
backend P1 Should have

Comments

@manasaV3
Copy link
Contributor

manasaV3 commented Aug 21, 2024

Motivation

At present, Neuroglancer renders oriented points in the same manner as simple points, without incorporating the rotation vector component into the visualization. This potentially results in users only getting partial information from the visualization. This can be improved by adding the direction vector to the visualization.

The metacell team has updated the cryoet's neuroglancer repository with components for rending the orientation. This can be used for updating the existing visualization components.

Definition of Done

The oriented points are rendered in neuroglancer with rotational vectors.

Tasks

1. Integrate the new the precompute method for oriented point

The visualization precompute importer (ref: here) needs to be updated with changes (if required) to incorporate the oriented points visualization.

The method for generating the precompute (ref: here) maintains the existing signature, with an additional parameter of a default value. The integration needs to sanity check that the precomputation creates valid output objects of sharded precomputed data that can be rendered by neuroglancer.

2. Update the config layer generation

The visualization config importer (ref: here) needs to be updated with if required for the oriented points visualizations.

The method for generating the oriented point layer in neuroglancer (ref: here) should be integrated and validated to ensure it generates config that reflects the newer visualization

3. Regenerate the related components

Regenerate the annotation precomputes and neuroglancer config generations for all runs that have oriented point annotations.

4. Update Production

Sync data to production bucket after validating the data in staging, and update the neuroglancer field in tomogram table for datasets with oriented point annotaions.

Related PRs

chanzuckerberg/cryoet-data-portal-neuroglancer#13

@manasaV3 manasaV3 added P1 Should have backend labels Aug 22, 2024
@manasaV3 manasaV3 changed the title Update rendering of oriented points Update oriented point rendering in neuroglancer Aug 22, 2024
@junxini junxini added this to the sprint 4 (phase 3) milestone Aug 22, 2024
@junxini
Copy link
Contributor

junxini commented Aug 22, 2024

@manasaV3 + @Bento007 to help with pointing

@manasaV3
Copy link
Contributor Author

@manasaV3
Copy link
Contributor Author

@Bento007 Let me know if more information is needed for pointing this. :)

@Bento007 Bento007 removed their assignment Sep 4, 2024
@junxini
Copy link
Contributor

junxini commented Sep 5, 2024

this ticket will be to double check Metacell's solution recommendation

@junxini junxini removed this from the sprint 3 (phase 4) milestone Sep 5, 2024
@manasaV3
Copy link
Contributor Author

manasaV3 commented Sep 5, 2024

This issue should fix the bug raised in: chanzuckerberg/cryoet-data-portal-neuroglancer#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend P1 Should have
Projects
None yet
Development

No branches or pull requests

3 participants