Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/oriented points layer #13

Merged

Conversation

seankmartin
Copy link
Collaborator

@seankmartin seankmartin commented Jun 24, 2024

Adds an oriented point layer JSON generator, as well as an encoder for oriented point data as a set of three lines for each point.

The three lines would represent the rotated x, y, and z vectors for each point.

Along with adding this feature, some base annotation encoders and point annotation shader classes that can be used by child classes have been added. This is in an effort to make changes to the overall annotation strategy or shaders easier to propagate through the case base.

@seankmartin seankmartin requested a review from aranega June 24, 2024 17:49
Copy link
Collaborator

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me :) there is only the question about the "sharding.py" file that we could remove probably if we use the CloudVolume library (which is now a dependency of the project).

cryoet_data_portal_neuroglancer/precompute/sharding.py Outdated Show resolved Hide resolved
@seankmartin
Copy link
Collaborator Author

Hey @aranega , depending on cloud-volume sharding seems to have worked, you can see the changes in b34bb95

@seankmartin seankmartin marked this pull request as ready for review July 11, 2024 17:16
@seankmartin seankmartin merged commit 6eb4f80 into chanzuckerberg:main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants