-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/oriented points layer #13
Merged
seankmartin
merged 29 commits into
chanzuckerberg:main
from
seankmartin:feature/oriented-points-layer
Jul 11, 2024
Merged
Feature/oriented points layer #13
seankmartin
merged 29 commits into
chanzuckerberg:main
from
seankmartin:feature/oriented-points-layer
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankmartin
commented
Jun 24, 2024
aranega
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me :) there is only the question about the "sharding.py" file that we could remove probably if we use the CloudVolume library (which is now a dependency of the project).
Also pin numpy as latest < 2.0 due to issues
seankmartin
commented
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an oriented point layer JSON generator, as well as an encoder for oriented point data as a set of three lines for each point.
The three lines would represent the rotated x, y, and z vectors for each point.
Along with adding this feature, some base annotation encoders and point annotation shader classes that can be used by child classes have been added. This is in an effort to make changes to the overall annotation strategy or shaders easier to propagate through the case base.