Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toggle): create toggle specific t3 tokens #1637

Merged
merged 3 commits into from
May 30, 2023
Merged

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented May 26, 2023

EDS-993

Summary:

Test Plan:

  • CI tests / new tests are not applicable
    • no visual regressions

@jinlee93 jinlee93 requested a review from a team May 26, 2023 18:10
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1637 (c754d38) into next (a3cda57) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #1637      +/-   ##
==========================================
+ Coverage   93.25%   93.26%   +0.01%     
==========================================
  Files         222      222              
  Lines        2935     2941       +6     
  Branches      717      717              
==========================================
+ Hits         2737     2743       +6     
  Misses        181      181              
  Partials       17       17              
Impacted Files Coverage Δ
src/components/Toggle/Toggle.tsx 100.00% <ø> (ø)
src/tokens-dist/ts/colors.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 26, 2023

size-limit report 📦

Path Size
components 95.01 KB (0%)
styles 36.23 KB (+0.15% 🔺)

@jinlee93 jinlee93 changed the title refactor(toggle)!: create toggle specific t3 tokens refactor(toggle): create toggle specific t3 tokens May 26, 2023
Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks gooood 🚢

@@ -109,13 +109,13 @@
/**
* The unchecked state of the circle indicator.
*/
.toggle__button--unchecked > .toggle__button-circle {
.toggle__button--unchecked > .toggle__button-thumb {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jinlee93 jinlee93 merged commit b5d2be1 into next May 30, 2023
@jinlee93 jinlee93 deleted the jlee/toggleT3tokens branch May 30, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants