Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(link)!: remove text-link tokens for link t3 tokens #1639

Merged
merged 10 commits into from
Aug 14, 2023
Merged

refactor(link)!: remove text-link tokens for link t3 tokens #1639

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8cd31e1
refactor(link): create link specific t3 tokens
May 25, 2023
8df0269
refactor(link): add background t3 tokens
May 26, 2023
c3d23f9
Merge branch 'next' into jlee/linkt3tokens
May 26, 2023
4894847
refactor(link): point t3 tokens to t2 temp
May 26, 2023
7ba7221
refactor(link)!: point t3 to t1 tokens
May 26, 2023
00492c4
refactor!: remove deprecated tokens
May 27, 2023
b0af9c9
Merge branch 'next' into jlee/linkt3tot1
Jul 26, 2023
ddeed5f
fix(tabs): use correct color token
Jul 26, 2023
5eb3dc0
refactor(link): re-remove text-link tokens re-added in rebase
Jul 26, 2023
4faffa5
fix(tokens): point tier 3 tokens to relevant tier 2 token values
booc0mtaco Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .storybook/data/tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,6 @@
"eds-theme-color-background-grade-stop-default": "#D41E52",
"eds-theme-color-background-grade-stop-subtle": "#FFF0F4",
"eds-theme-color-background-disabled": "#C0C4C8",
"eds-theme-color-border-link-neutral": "#21272D",
"eds-theme-color-border-link-brand": "#5751D2",
"eds-theme-color-border-neutral-subtle": "#E7E8EA",
"eds-theme-color-border-neutral-subtle-hover": "#C0C4C8",
"eds-theme-color-border-neutral-default": "#C0C4C8",
Expand Down Expand Up @@ -278,8 +276,6 @@
"eds-theme-color-text-neutral-default-inverse": "#FFFFFF",
"eds-theme-color-text-neutral-strong": "#21272D",
"eds-theme-color-text-neutral-subtle": "#5D6369",
"eds-theme-color-text-link-neutral": "#21272D",
"eds-theme-color-text-link-brand": "#5751D2",
"eds-theme-color-text-utility-success": "#007249",
"eds-theme-color-text-utility-warning": "#AC3400",
"eds-theme-color-text-utility-error": "#BD0044",
Expand Down
2 changes: 1 addition & 1 deletion src/components/Tabs/Tabs.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
* Tabs link within active tabs item
*/
.tabs__item.eds-is-active & {
color: var(--eds-theme-color-text-link-brand);
color: var(--eds-theme-color-text-brand-default);
box-shadow: inset 0 calc(var(--eds-border-width-md) * -1) 0 0
var(--eds-theme-color-border-brand-primary-strong);
}
Expand Down
8 changes: 0 additions & 8 deletions src/tokens-dist/json/variables-nested.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,10 +371,6 @@
"disabled": "#C0C4C8"
},
"border": {
"link": {
"neutral": "#21272D",
"brand": "#5751D2"
},
"neutral": {
"subtle": {
"@": "#E7E8EA",
Expand Down Expand Up @@ -492,10 +488,6 @@
"strong": "#21272D",
"subtle": "#5D6369"
},
"link": {
"neutral": "#21272D",
"brand": "#5751D2"
},
"utility": {
"success": "#007249",
"warning": "#AC3400",
Expand Down